Issue 242223004: Rename macros TONATIVE_BOOL* and TOSTRING_BOOL to *_DEFAULT

Issue 242223004: Rename macros TONATIVE_BOOL* and TOSTRING_BOOL to *_DEFAULT (Closed)

Created:
6 years, 8 months ago by Nils Barth (inactive)

Modified:
6 years, 8 months ago

Reviewers:
haraken, pneubeck (no reviews)

CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, pneubeck (no reviews), yhirano

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename macros TONATIVE_BOOL* and TOSTRING_BOOL to *_DEFAULT These macros do not always take a boolean value; correction per comment by Philipp (pneubeck@): https://codereview.chromium.org/232563003/#msg30 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171925

Patch Set 1 #

Patch Set 2 : Fix comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -64 lines)			Patch
M	Source/bindings/v8/Dictionary.cpp	View		9 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/bindings/v8/ScriptController.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScriptEventListener.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScriptValue.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8Binding.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8Binding.cpp	View		9 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/bindings/v8/V8BindingMacros.h	View	1	3 chunks	+29 lines, -29 lines	0 comments	Download
M	Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/WorkerScriptController.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8BlobCustomHelpers.cpp	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 8 months ago (2014-04-18 05:32:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/242223004/20001

6 years, 8 months ago (2014-04-18 05:33:06 UTC) #4

Message was sent while issue was closed.

thanks

Expand Messages | Collapse Messages