Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp - Issue 242223004: Rename macros TONATIVE_BOOL* and TOSTRING_BOOL to *_DEFAULT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 242223004: Rename macros TONATIVE_BOOL* and TOSTRING_BOOL to *_DEFAULT (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

index b9a4a962a6113a107ab72e75edc5d55ef6319750..2aba517b372df028f7447d8a4d0059e54ec3d680 100644

--- a/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

@@ -62,7 +62,7 @@ static v8::Handle<v8::Value> getItem(HTMLAllCollection* collection, v8::Handle<v

{

v8::Local<v8::Uint32> index = argument->ToArrayIndex();

if (index.IsEmpty()) {

- TOSTRING_BOOL(V8StringResource<>, name, argument, v8::Undefined(info.GetIsolate()));

+ TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info.GetIsolate()));

v8::Handle<v8::Value> result = getNamedItems(collection, name, info);

if (result.IsEmpty())