Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: Source/bindings/v8/custom/V8BlobCustomHelpers.cpp

Issue 242223004: Rename macros TONATIVE_BOOL* and TOSTRING_BOOL to *_DEFAULT (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8BlobCustomHelpers.cpp
diff --git a/Source/bindings/v8/custom/V8BlobCustomHelpers.cpp b/Source/bindings/v8/custom/V8BlobCustomHelpers.cpp
index e1dc9670436f49e5d68a54e436891ff11a046642..b36a3c19f73cb5bafe828c59000b37f1dab08797 100644
--- a/Source/bindings/v8/custom/V8BlobCustomHelpers.cpp
+++ b/Source/bindings/v8/custom/V8BlobCustomHelpers.cpp
@@ -69,10 +69,10 @@ void ParsedProperties::setDefaultLastModified()
bool ParsedProperties::parseBlobPropertyBag(v8::Local<v8::Value> propertyBag, const char* blobClassName, ExceptionState& exceptionState, v8::Isolate* isolate)
{
- TONATIVE_BOOL(Dictionary, dictionary, Dictionary(propertyBag, isolate), false);
+ TONATIVE_DEFAULT(Dictionary, dictionary, Dictionary(propertyBag, isolate), false);
String endings;
- TONATIVE_BOOL(bool, containsEndings, dictionary.get("endings", endings), false);
+ TONATIVE_DEFAULT(bool, containsEndings, dictionary.get("endings", endings), false);
if (containsEndings) {
if (endings != "transparent" && endings != "native") {
exceptionState.throwTypeError("The 'endings' property must be either 'transparent' or 'native'.");
@@ -82,7 +82,7 @@ bool ParsedProperties::parseBlobPropertyBag(v8::Local<v8::Value> propertyBag, co
m_normalizeLineEndingsToNative = true;
}
- TONATIVE_BOOL(bool, containsType, dictionary.get("type", m_contentType), false);
+ TONATIVE_DEFAULT(bool, containsType, dictionary.get("type", m_contentType), false);
if (containsType) {
if (!m_contentType.containsOnlyASCII()) {
exceptionState.throwDOMException(SyntaxError, "The 'type' property must consist of ASCII characters.");
@@ -95,9 +95,9 @@ bool ParsedProperties::parseBlobPropertyBag(v8::Local<v8::Value> propertyBag, co
return true;
v8::Local<v8::Value> lastModified;
- TONATIVE_BOOL(bool, containsLastModified, dictionary.get("lastModified", lastModified), false);
+ TONATIVE_DEFAULT(bool, containsLastModified, dictionary.get("lastModified", lastModified), false);
if (containsLastModified) {
- TONATIVE_BOOL(long long, lastModifiedInt, toInt64(lastModified), false);
+ TONATIVE_DEFAULT(long long, lastModifiedInt, toInt64(lastModified), false);
setLastModified(static_cast<double>(lastModifiedInt) / msPerSecond);
} else {
setDefaultLastModified();
@@ -126,7 +126,7 @@ bool processBlobParts(v8::Local<v8::Object> blobParts, uint32_t blobPartsLength,
ASSERT(blob);
blob->appendTo(blobData);
} else {
- TOSTRING_BOOL(V8StringResource<>, stringValue, item, false);
+ TOSTRING_DEFAULT(V8StringResource<>, stringValue, item, false);
blobData.appendText(stringValue, normalizeLineEndingsToNative);
}
}
« no previous file with comments | « Source/bindings/v8/WorkerScriptController.cpp ('k') | Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698