Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2422073002: Reduce FOR_EACH_OBSERVER usage in ui/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, ozone-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, tdresser+watch_chromium.org, aboxhall+watch_chromium.org, shuchen+watch_chromium.org, oshima+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, dcheng, James Su, stevenjb+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce FOR_EACH_OBSERVER usage in ui/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08 Cr-Commit-Position: refs/heads/master@{#426098}

Patch Set 1 #

Total comments: 2

Patch Set 2 : explicit type #

Patch Set 3 : typo #

Total comments: 2

Patch Set 4 : remove space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -164 lines) Patch
M ui/accessibility/platform/ax_platform_node_win.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M ui/android/window_android.cc View 1 5 chunks +16 lines, -19 lines 0 comments Download
M ui/aura/env.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M ui/aura/test/test_cursor_client.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/test/test_focus_client.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ui/aura/window.cc View 1 13 chunks +30 lines, -28 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M ui/base/clipboard/clipboard_monitor.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/chromeos/ime_keyboard.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_base.cc View 1 3 chunks +8 lines, -9 lines 0 comments Download
M ui/base/ime/mock_input_method.cc View 1 4 chunks +14 lines, -14 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/win/osk_display_manager.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/chromeos/ime/candidate_window_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/chromeos/ime/input_method_menu_manager.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ui/chromeos/network/network_icon_animation.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/display/chromeos/display_configurator.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/display/display_change_notifier.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ui/display/display_list.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ui/display/fake_display_delegate.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/devices/device_data_manager.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M ui/events/ozone/device/device_manager_manual.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/platform/platform_event_source.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/sys_color_change_listener.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/win/singleton_hwnd.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/gpu_switching_manager.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/keyboard/keyboard_controller.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download
M ui/native_theme/native_theme.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_native_display_delegate.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/mus_thread_proxy.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/snapshot/screenshot_grabber.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Eric Willigers
This covers the cases skipped by https://codereview.chromium.org/2422873002/ https://codereview.chromium.org/2414453006/ https://codereview.chromium.org/2417613003/ https://codereview.chromium.org/2424603002/ https://codereview.chromium.org/2417463009/ https://codereview.chromium.org/2416963006/
4 years, 2 months ago (2016-10-17 01:16:02 UTC) #6
sky
https://codereview.chromium.org/2422073002/diff/1/ui/accessibility/platform/ax_platform_node_win.cc File ui/accessibility/platform/ax_platform_node_win.cc (right): https://codereview.chromium.org/2422073002/diff/1/ui/accessibility/platform/ax_platform_node_win.cc#newcode902 ui/accessibility/platform/ax_platform_node_win.cc:902: for (auto& observer : GetIAccessible2UsageObserverList()) Please do not use ...
4 years, 2 months ago (2016-10-17 15:30:55 UTC) #7
Eric Willigers
https://codereview.chromium.org/2422073002/diff/1/ui/accessibility/platform/ax_platform_node_win.cc File ui/accessibility/platform/ax_platform_node_win.cc (right): https://codereview.chromium.org/2422073002/diff/1/ui/accessibility/platform/ax_platform_node_win.cc#newcode902 ui/accessibility/platform/ax_platform_node_win.cc:902: for (auto& observer : GetIAccessible2UsageObserverList()) On 2016/10/17 15:30:55, sky ...
4 years, 2 months ago (2016-10-18 00:02:50 UTC) #8
sky
LGTM https://codereview.chromium.org/2422073002/diff/40001/ui/events/devices/device_data_manager.cc File ui/events/devices/device_data_manager.cc (right): https://codereview.chromium.org/2422073002/diff/40001/ui/events/devices/device_data_manager.cc#newcode17 ui/events/devices/device_data_manager.cc:17: for (InputDeviceEventObserver & observer : observers_) \ Remove ...
4 years, 2 months ago (2016-10-18 16:52:33 UTC) #13
Eric Willigers
https://codereview.chromium.org/2422073002/diff/40001/ui/events/devices/device_data_manager.cc File ui/events/devices/device_data_manager.cc (right): https://codereview.chromium.org/2422073002/diff/40001/ui/events/devices/device_data_manager.cc#newcode17 ui/events/devices/device_data_manager.cc:17: for (InputDeviceEventObserver & observer : observers_) \ On 2016/10/18 ...
4 years, 2 months ago (2016-10-18 22:55:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422073002/60001
4 years, 2 months ago (2016-10-18 22:56:23 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-19 00:16:13 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:05:10 UTC) #20
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/44bb427594f2418304cd165861f34e1faa060a08
Cr-Commit-Position: refs/heads/master@{#426098}

Powered by Google App Engine
This is Rietveld 408576698