Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Side by Side Diff: ui/android/window_android.cc

Issue 2422073002: Reduce FOR_EACH_OBSERVER usage in ui/ (Closed)
Patch Set: remove space Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/accessibility/platform/ax_platform_node_win.cc ('k') | ui/aura/env.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/android/window_android.h" 5 #include "ui/android/window_android.h"
6 6
7 #include "base/android/context_utils.h" 7 #include "base/android/context_utils.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 const JavaRef<jobject>& context = base::android::GetApplicationContext(); 48 const JavaRef<jobject>& context = base::android::GetApplicationContext();
49 return new WindowAndroid( 49 return new WindowAndroid(
50 env, Java_WindowAndroid_createForTesting(env, context).obj()); 50 env, Java_WindowAndroid_createForTesting(env, context).obj());
51 } 51 }
52 52
53 void WindowAndroid::DestroyForTesting() { 53 void WindowAndroid::DestroyForTesting() {
54 delete this; 54 delete this;
55 } 55 }
56 56
57 void WindowAndroid::OnCompositingDidCommit() { 57 void WindowAndroid::OnCompositingDidCommit() {
58 FOR_EACH_OBSERVER(WindowAndroidObserver, 58 for (WindowAndroidObserver& observer : observer_list_)
59 observer_list_, 59 observer.OnCompositingDidCommit();
60 OnCompositingDidCommit());
61 } 60 }
62 61
63 void WindowAndroid::AddObserver(WindowAndroidObserver* observer) { 62 void WindowAndroid::AddObserver(WindowAndroidObserver* observer) {
64 if (!observer_list_.HasObserver(observer)) 63 if (!observer_list_.HasObserver(observer))
65 observer_list_.AddObserver(observer); 64 observer_list_.AddObserver(observer);
66 } 65 }
67 66
68 void WindowAndroid::RemoveObserver(WindowAndroidObserver* observer) { 67 void WindowAndroid::RemoveObserver(WindowAndroidObserver* observer) {
69 observer_list_.RemoveObserver(observer); 68 observer_list_.RemoveObserver(observer);
70 } 69 }
71 70
72 void WindowAndroid::AttachCompositor(WindowAndroidCompositor* compositor) { 71 void WindowAndroid::AttachCompositor(WindowAndroidCompositor* compositor) {
73 if (compositor_ && compositor != compositor_) 72 if (compositor_ && compositor != compositor_)
74 DetachCompositor(); 73 DetachCompositor();
75 74
76 compositor_ = compositor; 75 compositor_ = compositor;
77 FOR_EACH_OBSERVER(WindowAndroidObserver, 76 for (WindowAndroidObserver& observer : observer_list_)
78 observer_list_, 77 observer.OnAttachCompositor();
79 OnAttachCompositor());
80 } 78 }
81 79
82 void WindowAndroid::DetachCompositor() { 80 void WindowAndroid::DetachCompositor() {
83 compositor_ = NULL; 81 compositor_ = NULL;
84 FOR_EACH_OBSERVER(WindowAndroidObserver, 82 for (WindowAndroidObserver& observer : observer_list_)
85 observer_list_, 83 observer.OnDetachCompositor();
86 OnDetachCompositor());
87 observer_list_.Clear(); 84 observer_list_.Clear();
88 } 85 }
89 86
90 void WindowAndroid::RequestVSyncUpdate() { 87 void WindowAndroid::RequestVSyncUpdate() {
91 JNIEnv* env = AttachCurrentThread(); 88 JNIEnv* env = AttachCurrentThread();
92 Java_WindowAndroid_requestVSyncUpdate(env, GetJavaObject()); 89 Java_WindowAndroid_requestVSyncUpdate(env, GetJavaObject());
93 } 90 }
94 91
95 void WindowAndroid::SetNeedsAnimate() { 92 void WindowAndroid::SetNeedsAnimate() {
96 if (compositor_) 93 if (compositor_)
97 compositor_->SetNeedsAnimate(); 94 compositor_->SetNeedsAnimate();
98 } 95 }
99 96
100 void WindowAndroid::Animate(base::TimeTicks begin_frame_time) { 97 void WindowAndroid::Animate(base::TimeTicks begin_frame_time) {
101 FOR_EACH_OBSERVER( 98 for (WindowAndroidObserver& observer : observer_list_)
102 WindowAndroidObserver, observer_list_, OnAnimate(begin_frame_time)); 99 observer.OnAnimate(begin_frame_time);
103 } 100 }
104 101
105 void WindowAndroid::OnVSync(JNIEnv* env, 102 void WindowAndroid::OnVSync(JNIEnv* env,
106 const JavaParamRef<jobject>& obj, 103 const JavaParamRef<jobject>& obj,
107 jlong time_micros, 104 jlong time_micros,
108 jlong period_micros) { 105 jlong period_micros) {
109 base::TimeTicks frame_time(base::TimeTicks::FromInternalValue(time_micros)); 106 base::TimeTicks frame_time(base::TimeTicks::FromInternalValue(time_micros));
110 base::TimeDelta vsync_period( 107 base::TimeDelta vsync_period(
111 base::TimeDelta::FromMicroseconds(period_micros)); 108 base::TimeDelta::FromMicroseconds(period_micros));
112 FOR_EACH_OBSERVER( 109 for (WindowAndroidObserver& observer : observer_list_)
113 WindowAndroidObserver, 110 observer.OnVSync(frame_time, vsync_period);
114 observer_list_,
115 OnVSync(frame_time, vsync_period));
116 if (compositor_) 111 if (compositor_)
117 compositor_->OnVSync(frame_time, vsync_period); 112 compositor_->OnVSync(frame_time, vsync_period);
118 } 113 }
119 114
120 void WindowAndroid::OnVisibilityChanged(JNIEnv* env, 115 void WindowAndroid::OnVisibilityChanged(JNIEnv* env,
121 const JavaParamRef<jobject>& obj, 116 const JavaParamRef<jobject>& obj,
122 bool visible) { 117 bool visible) {
123 FOR_EACH_OBSERVER(WindowAndroidObserver, observer_list_, 118 for (WindowAndroidObserver& observer : observer_list_)
124 OnRootWindowVisibilityChanged(visible)); 119 observer.OnRootWindowVisibilityChanged(visible);
125 } 120 }
126 121
127 void WindowAndroid::OnActivityStopped(JNIEnv* env, 122 void WindowAndroid::OnActivityStopped(JNIEnv* env,
128 const JavaParamRef<jobject>& obj) { 123 const JavaParamRef<jobject>& obj) {
129 FOR_EACH_OBSERVER(WindowAndroidObserver, observer_list_, OnActivityStopped()); 124 for (WindowAndroidObserver& observer : observer_list_)
125 observer.OnActivityStopped();
130 } 126 }
131 127
132 void WindowAndroid::OnActivityStarted(JNIEnv* env, 128 void WindowAndroid::OnActivityStarted(JNIEnv* env,
133 const JavaParamRef<jobject>& obj) { 129 const JavaParamRef<jobject>& obj) {
134 FOR_EACH_OBSERVER(WindowAndroidObserver, observer_list_, OnActivityStarted()); 130 for (WindowAndroidObserver& observer : observer_list_)
131 observer.OnActivityStarted();
135 } 132 }
136 133
137 bool WindowAndroid::HasPermission(const std::string& permission) { 134 bool WindowAndroid::HasPermission(const std::string& permission) {
138 JNIEnv* env = AttachCurrentThread(); 135 JNIEnv* env = AttachCurrentThread();
139 return Java_WindowAndroid_hasPermission( 136 return Java_WindowAndroid_hasPermission(
140 env, GetJavaObject(), 137 env, GetJavaObject(),
141 base::android::ConvertUTF8ToJavaString(env, permission)); 138 base::android::ConvertUTF8ToJavaString(env, permission));
142 } 139 }
143 140
144 bool WindowAndroid::CanRequestPermission(const std::string& permission) { 141 bool WindowAndroid::CanRequestPermission(const std::string& permission) {
(...skipping 11 matching lines...) Expand all
156 // ---------------------------------------------------------------------------- 153 // ----------------------------------------------------------------------------
157 // Native JNI methods 154 // Native JNI methods
158 // ---------------------------------------------------------------------------- 155 // ----------------------------------------------------------------------------
159 156
160 jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) { 157 jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
161 WindowAndroid* window = new WindowAndroid(env, obj); 158 WindowAndroid* window = new WindowAndroid(env, obj);
162 return reinterpret_cast<intptr_t>(window); 159 return reinterpret_cast<intptr_t>(window);
163 } 160 }
164 161
165 } // namespace ui 162 } // namespace ui
OLDNEW
« no previous file with comments | « ui/accessibility/platform/ax_platform_node_win.cc ('k') | ui/aura/env.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698