ui/chromeos/ime/input_method_menu_manager.cc - Issue 2422073002: Reduce FOR_EACH_OBSERVER usage in ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/chromeos/ime/input_method_menu_manager.cc

Issue 2422073002: Reduce FOR_EACH_OBSERVER usage in ui/ (Closed)

Patch Set: remove space Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/chromeos/ime/input_method_menu_manager.cc

diff --git a/ui/chromeos/ime/input_method_menu_manager.cc b/ui/chromeos/ime/input_method_menu_manager.cc

index f4032f83e7d793137a2b2b1e6d25ad43b6af6086..08c053f79988d0ad42147bac90714189bdafad94 100644

--- a/ui/chromeos/ime/input_method_menu_manager.cc

+++ b/ui/chromeos/ime/input_method_menu_manager.cc

@@ -35,9 +35,8 @@ InputMethodMenuManager::GetCurrentInputMethodMenuItemList() const {

void InputMethodMenuManager::SetCurrentInputMethodMenuItemList(

const InputMethodMenuItemList& menu_list) {

menu_list_ = menu_list;

- FOR_EACH_OBSERVER(InputMethodMenuManager::Observer,

- observers_,

- InputMethodMenuItemChanged(this));

+ for (InputMethodMenuManager::Observer& observer : observers_)

+ observer.InputMethodMenuItemChanged(this);

}

bool InputMethodMenuManager::HasInputMethodMenuItemForKey(