Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: ui/base/win/osk_display_manager.cc

Issue 2422073002: Reduce FOR_EACH_OBSERVER usage in ui/ (Closed)
Patch Set: remove space Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/win/osk_display_manager.h" 5 #include "ui/base/win/osk_display_manager.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 #include <shlobj.h> 9 #include <shlobj.h>
10 #include <shobjidl.h> // Must be before propkey. 10 #include <shobjidl.h> // Must be before propkey.
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 FROM_HERE, base::Bind(&OnScreenKeyboardDetector::HideIfNecessary, 212 FROM_HERE, base::Bind(&OnScreenKeyboardDetector::HideIfNecessary,
213 keyboard_detector_factory_.GetWeakPtr()), 213 keyboard_detector_factory_.GetWeakPtr()),
214 base::TimeDelta::FromMilliseconds(kCheckOSKDelayMs)); 214 base::TimeDelta::FromMilliseconds(kCheckOSKDelayMs));
215 } 215 }
216 } 216 }
217 217
218 void OnScreenKeyboardDetector::HandleKeyboardVisible() { 218 void OnScreenKeyboardDetector::HandleKeyboardVisible() {
219 DCHECK(!osk_visible_notification_received_); 219 DCHECK(!osk_visible_notification_received_);
220 osk_visible_notification_received_ = true; 220 osk_visible_notification_received_ = true;
221 221
222 FOR_EACH_OBSERVER(OnScreenKeyboardObserver, observers_, 222 for (OnScreenKeyboardObserver& observer : observers_)
223 OnKeyboardVisible(osk_rect_pixels_)); 223 observer.OnKeyboardVisible(osk_rect_pixels_);
224 224
225 // Now that the keyboard is visible, run the task to detect if it was hidden. 225 // Now that the keyboard is visible, run the task to detect if it was hidden.
226 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( 226 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
227 FROM_HERE, base::Bind(&OnScreenKeyboardDetector::HideIfNecessary, 227 FROM_HERE, base::Bind(&OnScreenKeyboardDetector::HideIfNecessary,
228 keyboard_detector_factory_.GetWeakPtr()), 228 keyboard_detector_factory_.GetWeakPtr()),
229 base::TimeDelta::FromMilliseconds(kCheckOSKDelayMs)); 229 base::TimeDelta::FromMilliseconds(kCheckOSKDelayMs));
230 } 230 }
231 231
232 void OnScreenKeyboardDetector::HandleKeyboardHidden() { 232 void OnScreenKeyboardDetector::HandleKeyboardHidden() {
233 osk_visible_notification_received_ = false; 233 osk_visible_notification_received_ = false;
234 FOR_EACH_OBSERVER(OnScreenKeyboardObserver, observers_, 234 for (OnScreenKeyboardObserver& observer : observers_)
235 OnKeyboardHidden(osk_rect_pixels_)); 235 observer.OnKeyboardHidden(osk_rect_pixels_);
236 ClearObservers(); 236 ClearObservers();
237 } 237 }
238 238
239 void OnScreenKeyboardDetector::ClearObservers() { 239 void OnScreenKeyboardDetector::ClearObservers() {
240 for (auto& observer : observers_) 240 for (auto& observer : observers_)
241 RemoveObserver(&observer); 241 RemoveObserver(&observer);
242 } 242 }
243 243
244 // OnScreenKeyboardDisplayManager member definitions. 244 // OnScreenKeyboardDisplayManager member definitions.
245 OnScreenKeyboardDisplayManager::OnScreenKeyboardDisplayManager() {} 245 OnScreenKeyboardDisplayManager::OnScreenKeyboardDisplayManager() {}
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 return false; 354 return false;
355 } 355 }
356 common_program_files_path = common_program_files; 356 common_program_files_path = common_program_files;
357 } 357 }
358 osk_path->insert(common_program_files_offset, common_program_files_path); 358 osk_path->insert(common_program_files_offset, common_program_files_path);
359 } 359 }
360 return !osk_path->empty(); 360 return !osk_path->empty();
361 } 361 }
362 362
363 } // namespace ui 363 } // namespace ui
OLDNEW
« no previous file with comments | « ui/base/user_activity/user_activity_detector.cc ('k') | ui/chromeos/ime/candidate_window_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698