Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 24220003: Remove default isolate usage from almost all tests (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years ago
Reviewers:
Sven Panne, marja
CC:
v8-dev
Visibility:
Public.

Description

Remove default isolate usage from almost all tests R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16809

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -244 lines) Patch
M include/v8-debug.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/api.cc View 4 chunks +10 lines, -3 lines 1 comment Download
M src/isolate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/v8threads.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.h View 3 chunks +27 lines, -18 lines 0 comments Download
M test/cctest/cctest.cc View 4 chunks +29 lines, -7 lines 0 comments Download
M test/cctest/test-api.cc View 9 chunks +13 lines, -97 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M test/cctest/test-debug.cc View 53 chunks +106 lines, -91 lines 1 comment Download
M test/cctest/test-lockers.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
7 years, 3 months ago (2013-09-18 15:22:48 UTC) #1
Sven Panne
lgtm https://codereview.chromium.org/24220003/diff/1/src/api.cc File src/api.cc (left): https://codereview.chromium.org/24220003/diff/1/src/api.cc#oldcode5427 src/api.cc:5427: i::Isolate::EnsureDefaultIsolate(); Let's hope that there are no arcane ...
7 years, 3 months ago (2013-09-19 06:42:36 UTC) #2
dcarney
Committed patchset #1 manually as r16809 (presubmit successful).
7 years, 3 months ago (2013-09-19 07:34:04 UTC) #3
marja
7 years ago (2013-12-02 15:40:45 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/24220003/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

https://codereview.chromium.org/24220003/diff/1/test/cctest/test-debug.cc#new...
test/cctest/test-debug.cc:7553: v8::Debug::SetLiveEditEnabled(false),
env->GetIsolate();
FYI, I'm fixing the C++ misuse of this old CL here:
https://codereview.chromium.org/99043004

<3 the accidental comma operator...

Powered by Google App Engine
This is Rietveld 408576698