Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: test/cctest/test-lockers.cc

Issue 24220003: Remove default isolate usage from almost all tests (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2007-2011 the V8 project authors. All rights reserved. 1 // Copyright 2007-2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 617 matching lines...) Expand 10 before | Expand all | Expand 10 after
628 } 628 }
629 } 629 }
630 } 630 }
631 631
632 private: 632 private:
633 v8::Persistent<v8::Context> context_; 633 v8::Persistent<v8::Context> context_;
634 }; 634 };
635 635
636 636
637 // Locker inside an Unlocker inside a Locker for default isolate. 637 // Locker inside an Unlocker inside a Locker for default isolate.
638 TEST(LockUnlockLockDefaultIsolateMultithreaded) { 638 UNINITIALIZED_TEST(LockUnlockLockDefaultIsolateMultithreaded) {
639 #if V8_TARGET_ARCH_MIPS 639 #if V8_TARGET_ARCH_MIPS
640 const int kNThreads = 50; 640 const int kNThreads = 50;
641 #else 641 #else
642 const int kNThreads = 100; 642 const int kNThreads = 100;
643 #endif 643 #endif
644 Local<v8::Context> context; 644 Local<v8::Context> context;
645 i::List<JoinableThread*> threads(kNThreads); 645 i::List<JoinableThread*> threads(kNThreads);
646 { 646 {
647 v8::Locker locker_(CcTest::default_isolate()); 647 v8::Locker locker_(CcTest::default_isolate());
648 v8::HandleScope handle_scope(CcTest::default_isolate()); 648 v8::HandleScope handle_scope(CcTest::default_isolate());
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 kSimpleExtensionSource)); 731 kSimpleExtensionSource));
732 const char* extension_names[] = { "test0", "test1", 732 const char* extension_names[] = { "test0", "test1",
733 "test2", "test3", "test4", 733 "test2", "test3", "test4",
734 "test5", "test6", "test7" }; 734 "test5", "test6", "test7" };
735 i::List<JoinableThread*> threads(kNThreads); 735 i::List<JoinableThread*> threads(kNThreads);
736 for (int i = 0; i < kNThreads; i++) { 736 for (int i = 0; i < kNThreads; i++) {
737 threads.Add(new IsolateGenesisThread(8, extension_names)); 737 threads.Add(new IsolateGenesisThread(8, extension_names));
738 } 738 }
739 StartJoinAndDeleteThreads(threads); 739 StartJoinAndDeleteThreads(threads);
740 } 740 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698