Issue 99043004: Fix: test-debug.cc: don't misuse C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99043004: Fix: test-debug.cc: don't misuse C++. (Closed)

Created:
7 years ago by marja

Modified:
7 years ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix: test-debug.cc: don't misuse C++. The test in question (test-debug/LiveEditEnabled) is expected to fail, and it failed, but because of the wrong reason (the test asserts that the default isolate is not initialized, SetLiveEditEnabled initialized the default isolate because it doesn't get one as param). Now it fails because of the right reason. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18203

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	test/cctest/test-debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r18203 (presubmit successful).

Expand Messages | Collapse Messages