Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: test/cctest/test-log.cc

Issue 24220003: Remove default isolate usage from almost all tests (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 318
319 // Must not crash. 319 // Must not crash.
320 i::Isolate::Current()->logger()->LogCompiledFunctions(); 320 i::Isolate::Current()->logger()->LogCompiledFunctions();
321 } 321 }
322 322
323 323
324 static void ObjMethod1(const v8::FunctionCallbackInfo<v8::Value>& args) { 324 static void ObjMethod1(const v8::FunctionCallbackInfo<v8::Value>& args) {
325 } 325 }
326 326
327 327
328 TEST(LogCallbacks) { 328 UNINITIALIZED_TEST(LogCallbacks) {
329 ScopedLoggerInitializer initialize_logger; 329 ScopedLoggerInitializer initialize_logger;
330 Logger* logger = initialize_logger.logger(); 330 Logger* logger = initialize_logger.logger();
331 331
332 v8::Local<v8::FunctionTemplate> obj = 332 v8::Local<v8::FunctionTemplate> obj =
333 v8::Local<v8::FunctionTemplate>::New(v8::Isolate::GetCurrent(), 333 v8::Local<v8::FunctionTemplate>::New(v8::Isolate::GetCurrent(),
334 v8::FunctionTemplate::New()); 334 v8::FunctionTemplate::New());
335 obj->SetClassName(v8_str("Obj")); 335 obj->SetClassName(v8_str("Obj"));
336 v8::Handle<v8::ObjectTemplate> proto = obj->PrototypeTemplate(); 336 v8::Handle<v8::ObjectTemplate> proto = obj->PrototypeTemplate();
337 v8::Local<v8::Signature> signature = v8::Signature::New(obj); 337 v8::Local<v8::Signature> signature = v8::Signature::New(obj);
338 proto->Set(v8_str("method1"), 338 proto->Set(v8_str("method1"),
(...skipping 28 matching lines...) Expand all
367 static void Prop1Setter(v8::Local<v8::String> property, 367 static void Prop1Setter(v8::Local<v8::String> property,
368 v8::Local<v8::Value> value, 368 v8::Local<v8::Value> value,
369 const v8::PropertyCallbackInfo<void>& info) { 369 const v8::PropertyCallbackInfo<void>& info) {
370 } 370 }
371 371
372 static void Prop2Getter(v8::Local<v8::String> property, 372 static void Prop2Getter(v8::Local<v8::String> property,
373 const v8::PropertyCallbackInfo<v8::Value>& info) { 373 const v8::PropertyCallbackInfo<v8::Value>& info) {
374 } 374 }
375 375
376 376
377 TEST(LogAccessorCallbacks) { 377 UNINITIALIZED_TEST(LogAccessorCallbacks) {
378 ScopedLoggerInitializer initialize_logger; 378 ScopedLoggerInitializer initialize_logger;
379 Logger* logger = initialize_logger.logger(); 379 Logger* logger = initialize_logger.logger();
380 380
381 v8::Local<v8::FunctionTemplate> obj = 381 v8::Local<v8::FunctionTemplate> obj =
382 v8::Local<v8::FunctionTemplate>::New(v8::Isolate::GetCurrent(), 382 v8::Local<v8::FunctionTemplate>::New(v8::Isolate::GetCurrent(),
383 v8::FunctionTemplate::New()); 383 v8::FunctionTemplate::New());
384 obj->SetClassName(v8_str("Obj")); 384 obj->SetClassName(v8_str("Obj"));
385 v8::Handle<v8::ObjectTemplate> inst = obj->InstanceTemplate(); 385 v8::Handle<v8::ObjectTemplate> inst = obj->InstanceTemplate();
386 inst->SetAccessor(v8_str("prop1"), Prop1Getter, Prop1Setter); 386 inst->SetAccessor(v8_str("prop1"), Prop1Getter, Prop1Setter);
387 inst->SetAccessor(v8_str("prop2"), Prop2Getter); 387 inst->SetAccessor(v8_str("prop2"), Prop2Getter);
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 v8::Local<v8::String> s = result->ToString(); 474 v8::Local<v8::String> s = result->ToString();
475 i::ScopedVector<char> data(s->Utf8Length() + 1); 475 i::ScopedVector<char> data(s->Utf8Length() + 1);
476 CHECK_NE(NULL, data.start()); 476 CHECK_NE(NULL, data.start());
477 s->WriteUtf8(data.start()); 477 s->WriteUtf8(data.start());
478 printf("%s\n", data.start()); 478 printf("%s\n", data.start());
479 // Make sure that our output is written prior crash due to CHECK failure. 479 // Make sure that our output is written prior crash due to CHECK failure.
480 fflush(stdout); 480 fflush(stdout);
481 CHECK(false); 481 CHECK(false);
482 } 482 }
483 } 483 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698