Fix import/export annotations for v8 targets that are always static

Fix import/export annotations for v8 targets that are always static

Instead of suppressing the linker warnings and disallowing incremental
linking, just fix the annotations..

R=machenbach@chromium.org,jgruber@chromium.org
BUG=

Committed: https://crrev.com/29ddd7ff82a410136250d03b4c741e2b8899a608
Cr-Commit-Position: refs/heads/master@{#40260}

[jochen (gone - plz use gerrit), 2016-10-13 11:09:40]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[jochen (gone - plz use gerrit), 2016-10-13 11:09:43]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 11:09:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-13 11:36:17]

lgtm

https://codereview.chromium.org/2420603002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2420603002/diff/1/BUILD.gn#newcode2405
BUILD.gn:2405: ":v8_maybe_snapshot",
Just checking - the distinction between fuzzer_support and
fuzzer_support_nocomponent is still needed because of the deps?

https://codereview.chromium.org/2420603002/diff/1/test/fuzzer/fuzzer.gyp
File test/fuzzer/fuzzer.gyp (right):

https://codereview.chromium.org/2420603002/diff/1/test/fuzzer/fuzzer.gyp#newc...
test/fuzzer/fuzzer.gyp:64: # fuzzers can't be built against a shared library, so
we need to
I don't understand this comment. Most fuzzers are being built against shared
libraries, no?

[Michael Achenbach, 2016-10-13 11:39:30]

https://codereview.chromium.org/2420603002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2420603002/diff/1/BUILD.gn#newcode2666
BUILD.gn:2666: defines += [ "BUILDING_V8_SHARED" ]
Is this reflected in gyp?

https://codereview.chromium.org/2420603002/diff/1/test/fuzzer/fuzzer.gyp
File test/fuzzer/fuzzer.gyp (right):

https://codereview.chromium.org/2420603002/diff/1/test/fuzzer/fuzzer.gyp#newc...
test/fuzzer/fuzzer.gyp:423: # fuzzers can't be built against a shared library,
so we need to
I guess already this old comment is imprecise. It really only means one
particular fuzzer.

[commit-bot: I haz the power, 2016-10-13 11:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 11:41:48]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-10-13 12:16:34]

https://codereview.chromium.org/2420603002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2420603002/diff/1/BUILD.gn#newcode2405
BUILD.gn:2405: ":v8_maybe_snapshot",
On 2016/10/13 at 11:36:17, jgruber wrote:
> Just checking - the distinction between fuzzer_support and
fuzzer_support_nocomponent is still needed because of the deps?

that's mostly because of missing export annotations in the parser. I can fix
that in a follow-up cl

https://codereview.chromium.org/2420603002/diff/1/BUILD.gn#newcode2666
BUILD.gn:2666: defines += [ "BUILDING_V8_SHARED" ]
On 2016/10/13 at 11:39:30, machenbach (slow) wrote:
> Is this reflected in gyp?

parser shell just doesn't work in gyp/shared_library

https://codereview.chromium.org/2420603002/diff/1/test/fuzzer/fuzzer.gyp
File test/fuzzer/fuzzer.gyp (right):

https://codereview.chromium.org/2420603002/diff/1/test/fuzzer/fuzzer.gyp#newc...
test/fuzzer/fuzzer.gyp:64: # fuzzers can't be built against a shared library, so
we need to
On 2016/10/13 at 11:36:17, jgruber wrote:
> I don't understand this comment. Most fuzzers are being built against shared
libraries, no?

right, that's a copy of the comment below. I'll remove it

[Michael Achenbach, 2016-10-13 12:17:11]

lgtm

[jochen (gone - plz use gerrit), 2016-10-13 12:17:26]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-10-13 12:17:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
jgruber@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2420603002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2016-10-13 12:17:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 12:44:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 12:44:43]

Description was changed from

==========
Fix import/export annotations for v8 targets that are always static

Instead of suppressing the linker warnings and disallowing incremental
linking, just fix the annotations..

R=machenbach@chromium.org,jgruber@chromium.org
BUG=
==========

to

==========
Fix import/export annotations for v8 targets that are always static

Instead of suppressing the linker warnings and disallowing incremental
linking, just fix the annotations..

R=machenbach@chromium.org,jgruber@chromium.org
BUG=

Committed: https://crrev.com/29ddd7ff82a410136250d03b4c741e2b8899a608
Cr-Commit-Position: refs/heads/master@{#40260}
==========

[commit-bot: I haz the power, 2016-10-13 12:44:44]

Patchset 2 (id:??) landed as
https://crrev.com/29ddd7ff82a410136250d03b4c741e2b8899a608
Cr-Commit-Position: refs/heads/master@{#40260}