include/v8.h - Issue 2420603002: Fix import/export annotations for v8 targets that are always static

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 2420603002: Fix import/export annotations for v8 targets that are always static (Closed)

Patch Set: updates Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index ad6db7d1e5949429f3f43ec577e47fbe93af9901..56bfc0ff5088af44c930456044524dda35e2b92a 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -35,11 +35,6 @@

// the V8 DLL USING_V8_SHARED needs to be defined. When either building the V8

// static library or building a program which uses the V8 static library neither

// BUILDING_V8_SHARED nor USING_V8_SHARED should be defined.

-#if defined(BUILDING_V8_SHARED) && defined(USING_V8_SHARED)

-#error both BUILDING_V8_SHARED and USING_V8_SHARED are set - please check the\

- build configuration to ensure that at most one of these is set

-#endif

#ifdef BUILDING_V8_SHARED

# define V8_EXPORT __declspec(dllexport)

#elif USING_V8_SHARED

« no previous file with comments | « BUILD.gn ('k') | test/cctest/BUILD.gn » ('j') | no next file with comments »