Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: BUILD.gn

Issue 2420603002: Fix import/export annotations for v8 targets that are always static (Closed)
Patch Set: updates Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index ace692a565bf0e6a9cac89e952d9e44082395d1a..83816842fb424de68d9f543b6cdb9dee9963b029 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2405,6 +2405,10 @@ v8_source_set("fuzzer_support_nocomponent") {
":v8_maybe_snapshot",
]
+ if (is_component_build) {
+ defines = [ "BUILDING_V8_SHARED" ]
+ }
+
public_deps = [
":v8_libbase",
":v8_libplatform",
@@ -2653,10 +2657,13 @@ v8_executable("v8_parser_shell") {
"//build/win:default_exe_manifest",
]
+ defines = []
+
if (is_component_build) {
# v8_parser_shell can't be built against a shared library, so we
# need to depend on the underlying static target in that case.
deps += [ ":v8_maybe_snapshot" ]
+ defines += [ "BUILDING_V8_SHARED" ]
} else {
deps += [ ":v8" ]
}
@@ -2744,6 +2751,10 @@ v8_source_set("parser_fuzzer") {
":fuzzer_support_nocomponent",
]
+ if (is_component_build) {
+ defines = [ "BUILDING_V8_SHARED" ]
+ }
+
configs = [
":external_config",
":internal_config_base",
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698