Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: test/unittests/BUILD.gn

Issue 2420603002: Fix import/export annotations for v8 targets that are always static (Closed)
Patch Set: updates Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/fuzzer/fuzzer.gyp ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/BUILD.gn
diff --git a/test/unittests/BUILD.gn b/test/unittests/BUILD.gn
index 625a3d0082671b3f5af5907d118d694ad19d6e03..e5f66ae94b7775cb8843354feb7f1f0dedd3b208 100644
--- a/test/unittests/BUILD.gn
+++ b/test/unittests/BUILD.gn
@@ -153,11 +153,6 @@ v8_executable("unittests") {
"../..:internal_config_base",
]
- if (is_win) {
- remove_configs = [ "//build/config/win:default_incremental_linking" ]
- configs += [ "//build/config/win:no_incremental_linking" ]
- }
-
# TODO(machenbach): Translate from gyp.
#['OS=="aix"', {
# 'ldflags': [ '-Wl,-bbigtoc' ],
@@ -172,10 +167,13 @@ v8_executable("unittests") {
"//testing/gtest",
]
+ defines = []
+
if (is_component_build) {
# compiler-unittests can't be built against a shared library, so we
# need to depend on the underlying static target in that case.
deps += [ "../..:v8_maybe_snapshot" ]
+ defines += [ "BUILDING_V8_SHARED" ]
} else {
deps += [ "../..:v8" ]
}
@@ -185,13 +183,5 @@ v8_executable("unittests") {
# bytecode-utils.h.
# C4309: 'static_cast': truncation of constant value
cflags = [ "/wd4309" ]
-
- # Suppress warnings about importing locally defined symbols.
- if (is_component_build) {
- ldflags = [
- "/ignore:4049",
- "/ignore:4217",
- ]
- }
}
}
« no previous file with comments | « test/fuzzer/fuzzer.gyp ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698