Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 2419943002: [DevTools] Migrate from AgentStateCallbacks to DevToolsAgentHostObserver. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
Finnur, pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, jam, darin-cc_chromium.org, blink-worker-reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate from AgentStateCallbacks to DevToolsAgentHostObserver. - This allows to add more methods to observer. - Migrated clients. - Issuing notifications from the base class. BUG=648775 TBR=bauerb@chromium.org,avi@chormium.org Committed: https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e Cr-Commit-Position: refs/heads/master@{#425714}

Patch Set 1 #

Patch Set 2 : fix, mm #

Patch Set 3 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -181 lines) Patch
M chrome/browser/android/devtools_manager_delegate_android.h View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/android/devtools_manager_delegate_android.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 2 3 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.h View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 4 chunks +15 lines, -16 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 1 8 chunks +39 lines, -28 lines 0 comments Download
M content/browser/devtools/devtools_manager.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_manager.cc View 1 chunk +1 line, -25 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/devtools_agent_host.h View 3 chunks +5 lines, -6 lines 0 comments Download
A content/public/browser/devtools_agent_host_observer.h View 1 chunk +25 lines, -0 lines 0 comments Download
M content/public/browser/devtools_manager_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/devtools_manager_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/app_window/app_window_registry.h View 4 chunks +11 lines, -5 lines 0 comments Download
M extensions/browser/app_window/app_window_registry.cc View 3 chunks +21 lines, -19 lines 0 comments Download
M extensions/browser/process_manager.h View 4 chunks +11 lines, -4 lines 0 comments Download
M extensions/browser/process_manager.cc View 3 chunks +18 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 32 (22 generated)
dgozman
Could you please take a look?
4 years, 2 months ago (2016-10-14 01:07:55 UTC) #4
pfeldman
lgtm
4 years, 2 months ago (2016-10-14 02:22:44 UTC) #7
dgozman
@finnur: could you please take a look at extension files?
4 years, 2 months ago (2016-10-14 19:56:57 UTC) #15
Finnur
Extensions OWNERS LGTM
4 years, 2 months ago (2016-10-17 10:42:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419943002/40001
4 years, 2 months ago (2016-10-17 14:52:13 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/282563)
4 years, 2 months ago (2016-10-17 15:02:56 UTC) #23
dgozman
TBR'ing bauerb@ for c/b/android, avi@ for c/b/ui/cocoa/extensions.
4 years, 2 months ago (2016-10-17 17:24:40 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2419943002/40001
4 years, 2 months ago (2016-10-17 17:25:23 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 17:30:44 UTC) #30
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 17:33:56 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47679eb123c83bec2bb19d54b0386c67f7e6859e
Cr-Commit-Position: refs/heads/master@{#425714}

Powered by Google App Engine
This is Rietveld 408576698