Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.h

Issue 2419943002: [DevTools] Migrate from AgentStateCallbacks to DevToolsAgentHostObserver. (Closed)
Patch Set: mac Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
6 #define CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_ 6 #define CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <set> 9 #include <set>
10 10
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "chrome/browser/devtools/device/devtools_android_bridge.h" 13 #include "chrome/browser/devtools/device/devtools_android_bridge.h"
14 #include "content/public/browser/devtools_agent_host_observer.h"
14 #include "content/public/browser/devtools_manager_delegate.h" 15 #include "content/public/browser/devtools_manager_delegate.h"
15 #include "net/base/host_port_pair.h" 16 #include "net/base/host_port_pair.h"
16 17
17 class DevToolsNetworkProtocolHandler; 18 class DevToolsNetworkProtocolHandler;
18 19
19 class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate { 20 class ChromeDevToolsManagerDelegate :
21 public content::DevToolsManagerDelegate,
22 public content::DevToolsAgentHostObserver {
20 public: 23 public:
21 static char kTypeApp[]; 24 static char kTypeApp[];
22 static char kTypeBackgroundPage[]; 25 static char kTypeBackgroundPage[];
23 static char kTypeWebView[]; 26 static char kTypeWebView[];
24 27
25 ChromeDevToolsManagerDelegate(); 28 ChromeDevToolsManagerDelegate();
26 ~ChromeDevToolsManagerDelegate() override; 29 ~ChromeDevToolsManagerDelegate() override;
27 30
31 private:
28 // content::DevToolsManagerDelegate implementation. 32 // content::DevToolsManagerDelegate implementation.
29 void Inspect(content::DevToolsAgentHost* agent_host) override; 33 void Inspect(content::DevToolsAgentHost* agent_host) override;
30 void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,
31 bool attached) override;
32 bool DiscoverTargets( 34 bool DiscoverTargets(
33 const content::DevToolsAgentHost::DiscoveryCallback& callback) override; 35 const content::DevToolsAgentHost::DiscoveryCallback& callback) override;
34 base::DictionaryValue* HandleCommand( 36 base::DictionaryValue* HandleCommand(
35 content::DevToolsAgentHost* agent_host, 37 content::DevToolsAgentHost* agent_host,
36 base::DictionaryValue* command_dict) override; 38 base::DictionaryValue* command_dict) override;
37 std::string GetTargetType(content::RenderFrameHost* host) override; 39 std::string GetTargetType(content::RenderFrameHost* host) override;
38 std::string GetTargetTitle(content::RenderFrameHost* host) override; 40 std::string GetTargetTitle(content::RenderFrameHost* host) override;
39 scoped_refptr<content::DevToolsAgentHost> CreateNewTarget( 41 scoped_refptr<content::DevToolsAgentHost> CreateNewTarget(
40 const GURL& url) override; 42 const GURL& url) override;
41 std::string GetDiscoveryPageHTML() override; 43 std::string GetDiscoveryPageHTML() override;
42 std::string GetFrontendResource(const std::string& path) override; 44 std::string GetFrontendResource(const std::string& path) override;
43 45
44 private: 46 // content::DevToolsAgentHostObserver overrides.
47 void DevToolsAgentHostAttached(
48 content::DevToolsAgentHost* agent_host) override;
49 void DevToolsAgentHostDetached(
50 content::DevToolsAgentHost* agent_host) override;
51
45 void DevicesAvailable( 52 void DevicesAvailable(
46 const content::DevToolsAgentHost::DiscoveryCallback& callback, 53 const content::DevToolsAgentHost::DiscoveryCallback& callback,
47 const DevToolsAndroidBridge::CompleteDevices& devices); 54 const DevToolsAndroidBridge::CompleteDevices& devices);
48 55
49 std::unique_ptr<base::DictionaryValue> SetRemoteLocations( 56 std::unique_ptr<base::DictionaryValue> SetRemoteLocations(
50 content::DevToolsAgentHost* agent_host, 57 content::DevToolsAgentHost* agent_host,
51 int command_id, 58 int command_id,
52 base::DictionaryValue* params); 59 base::DictionaryValue* params);
53 60
54 std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_; 61 std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;
55 std::unique_ptr<AndroidDeviceManager> device_manager_; 62 std::unique_ptr<AndroidDeviceManager> device_manager_;
56 std::set<net::HostPortPair> tcp_locations_; 63 std::set<net::HostPortPair> tcp_locations_;
57 64
58 DISALLOW_COPY_AND_ASSIGN(ChromeDevToolsManagerDelegate); 65 DISALLOW_COPY_AND_ASSIGN(ChromeDevToolsManagerDelegate);
59 }; 66 };
60 67
61 #endif // CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_ 68 #endif // CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698