Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: chrome/browser/android/devtools_manager_delegate_android.h

Issue 2419943002: [DevTools] Migrate from AgentStateCallbacks to DevToolsAgentHostObserver. (Closed)
Patch Set: mac Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/devtools_manager_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/devtools_manager_delegate_android.h
diff --git a/chrome/browser/android/devtools_manager_delegate_android.h b/chrome/browser/android/devtools_manager_delegate_android.h
index 90f4e07408f1ec9b55ba290621567636e1e34596..8b9f8177406440c59a093b23dcca825e4271111b 100644
--- a/chrome/browser/android/devtools_manager_delegate_android.h
+++ b/chrome/browser/android/devtools_manager_delegate_android.h
@@ -9,18 +9,20 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "content/public/browser/devtools_agent_host_observer.h"
#include "content/public/browser/devtools_manager_delegate.h"
class DevToolsNetworkProtocolHandler;
-class DevToolsManagerDelegateAndroid : public content::DevToolsManagerDelegate {
+class DevToolsManagerDelegateAndroid :
+ public content::DevToolsManagerDelegate,
+ public content::DevToolsAgentHostObserver {
public:
DevToolsManagerDelegateAndroid();
~DevToolsManagerDelegateAndroid() override;
+ private:
// content::DevToolsManagerDelegate implementation.
- void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,
- bool attached) override;
base::DictionaryValue* HandleCommand(
content::DevToolsAgentHost* agent_host,
base::DictionaryValue* command_dict) override;
@@ -32,7 +34,12 @@ class DevToolsManagerDelegateAndroid : public content::DevToolsManagerDelegate {
const GURL& url) override;
std::string GetDiscoveryPageHTML() override;
- private:
+ // content::DevToolsAgentHostObserver overrides.
+ void DevToolsAgentHostAttached(
+ content::DevToolsAgentHost* agent_host) override;
+ void DevToolsAgentHostDetached(
+ content::DevToolsAgentHost* agent_host) override;
+
std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;
DISALLOW_COPY_AND_ASSIGN(DevToolsManagerDelegateAndroid);
« no previous file with comments | « no previous file | chrome/browser/android/devtools_manager_delegate_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698