Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/android/devtools_manager_delegate_android.h

Issue 2419943002: [DevTools] Migrate from AgentStateCallbacks to DevToolsAgentHostObserver. (Closed)
Patch Set: mac Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/devtools_manager_delegate_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "content/public/browser/devtools_agent_host_observer.h"
12 #include "content/public/browser/devtools_manager_delegate.h" 13 #include "content/public/browser/devtools_manager_delegate.h"
13 14
14 class DevToolsNetworkProtocolHandler; 15 class DevToolsNetworkProtocolHandler;
15 16
16 class DevToolsManagerDelegateAndroid : public content::DevToolsManagerDelegate { 17 class DevToolsManagerDelegateAndroid :
18 public content::DevToolsManagerDelegate,
19 public content::DevToolsAgentHostObserver {
17 public: 20 public:
18 DevToolsManagerDelegateAndroid(); 21 DevToolsManagerDelegateAndroid();
19 ~DevToolsManagerDelegateAndroid() override; 22 ~DevToolsManagerDelegateAndroid() override;
20 23
24 private:
21 // content::DevToolsManagerDelegate implementation. 25 // content::DevToolsManagerDelegate implementation.
22 void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,
23 bool attached) override;
24 base::DictionaryValue* HandleCommand( 26 base::DictionaryValue* HandleCommand(
25 content::DevToolsAgentHost* agent_host, 27 content::DevToolsAgentHost* agent_host,
26 base::DictionaryValue* command_dict) override; 28 base::DictionaryValue* command_dict) override;
27 std::string GetTargetType(content::RenderFrameHost* host) override; 29 std::string GetTargetType(content::RenderFrameHost* host) override;
28 std::string GetTargetTitle(content::RenderFrameHost* host) override; 30 std::string GetTargetTitle(content::RenderFrameHost* host) override;
29 bool DiscoverTargets( 31 bool DiscoverTargets(
30 const content::DevToolsAgentHost::DiscoveryCallback& callback) override; 32 const content::DevToolsAgentHost::DiscoveryCallback& callback) override;
31 scoped_refptr<content::DevToolsAgentHost> CreateNewTarget( 33 scoped_refptr<content::DevToolsAgentHost> CreateNewTarget(
32 const GURL& url) override; 34 const GURL& url) override;
33 std::string GetDiscoveryPageHTML() override; 35 std::string GetDiscoveryPageHTML() override;
34 36
35 private: 37 // content::DevToolsAgentHostObserver overrides.
38 void DevToolsAgentHostAttached(
39 content::DevToolsAgentHost* agent_host) override;
40 void DevToolsAgentHostDetached(
41 content::DevToolsAgentHost* agent_host) override;
42
36 std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_; 43 std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;
37 44
38 DISALLOW_COPY_AND_ASSIGN(DevToolsManagerDelegateAndroid); 45 DISALLOW_COPY_AND_ASSIGN(DevToolsManagerDelegateAndroid);
39 }; 46 };
40 47
41 #endif // CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_ 48 #endif // CHROME_BROWSER_ANDROID_DEVTOOLS_MANAGER_DELEGATE_ANDROID_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/devtools_manager_delegate_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698