Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2416433006: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/extensions (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/extensions BUG=581865 Committed: https://crrev.com/35d6d10e1af411ed2f18a64ae20daa24bfbef174 Cr-Commit-Position: refs/heads/master@{#425098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dcheng
4 years, 2 months ago (2016-10-13 17:46:15 UTC) #2
Devlin
lgtm
4 years, 2 months ago (2016-10-13 18:16:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416433006/1
4 years, 2 months ago (2016-10-13 18:20:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 18:28:54 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 18:30:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35d6d10e1af411ed2f18a64ae20daa24bfbef174
Cr-Commit-Position: refs/heads/master@{#425098}

Powered by Google App Engine
This is Rietveld 408576698