Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3639)

Unified Diff: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

Issue 2416433006: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/extensions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
diff --git a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
index 227a38e0db1d8ac2f96342f8a5d9bbc735d6fc8a..4d6598d9a6a418e0e988956a3dbc80450f306a93 100644
--- a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
+++ b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
@@ -244,16 +244,15 @@ void LogPrivateAPI::PostPendingEntries() {
void LogPrivateAPI::AddEntriesOnUI(std::unique_ptr<base::ListValue> value) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- for (std::set<std::string>::iterator ix = net_internal_watches_.begin();
- ix != net_internal_watches_.end(); ++ix) {
+ for (const std::string& extension_id : net_internal_watches_) {
// Create the event's arguments value.
std::unique_ptr<base::ListValue> event_args(new base::ListValue());
- event_args->Append(value->DeepCopy());
+ event_args->Append(value->CreateDeepCopy());
std::unique_ptr<Event> event(
new Event(::extensions::events::LOG_PRIVATE_ON_CAPTURED_EVENTS,
::events::kOnCapturedEvents, std::move(event_args)));
EventRouter::Get(browser_context_)
- ->DispatchEventToExtension(*ix, std::move(event));
+ ->DispatchEventToExtension(extension_id, std::move(event));
}
}
« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698