Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/extensions

chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 
@@ skipping 246 matching lines @@
   std::string expected_result;
   client_->CreateSecureMessage(
       "PAYLOAD",
       create_options,
       base::Bind(&CopyData, &expected_result));
   ASSERT_GT(expected_result.length(), 0u);
 
   std::unique_ptr<base::ListValue> args(new base::ListValue);
   args->Append(StringToBinaryValue("PAYLOAD"));
   args->Append(StringToBinaryValue("KEY"));
-  base::DictionaryValue* options = new base::DictionaryValue();
-  args->Append(options);
+  auto options = base::MakeUnique<base::DictionaryValue>();
   options->Set("associatedData", StringToBinaryValue("ASSOCIATED_DATA"));
   options->Set("publicMetadata", StringToBinaryValue("PUBLIC_METADATA"));
   options->Set("verificationKeyId",
                StringToBinaryValue("VERIFICATION_KEY_ID"));
   options->Set("decryptionKeyId",
                StringToBinaryValue("DECRYPTION_KEY_ID"));
   options->SetString(
       "encryptType",
       api::ToString(api::ENCRYPTION_TYPE_AES_256_CBC));
   options->SetString(
       "signType",
       api::ToString(api::SIGNATURE_TYPE_HMAC_SHA256));
+  args->Append(std::move(options));
 
   ASSERT_TRUE(extension_function_test_utils::RunFunction(
       function.get(), std::move(args), browser(),
       extension_function_test_utils::NONE));
 
   EXPECT_EQ(expected_result, GetSingleBinaryResultAsString(function.get()));
 }
 
 TEST_F(EasyUnlockPrivateApiTest, CreateSecureMessage_EmptyOptions) {
   scoped_refptr<EasyUnlockPrivateCreateSecureMessageFunction> function(
@@ skipping 40 matching lines @@
   std::string expected_result;
   client_->CreateSecureMessage(
       "PAYLOAD",
       create_options,
       base::Bind(&CopyData, &expected_result));
   ASSERT_GT(expected_result.length(), 0u);
 
   std::unique_ptr<base::ListValue> args(new base::ListValue);
   args->Append(StringToBinaryValue("PAYLOAD"));
   args->Append(StringToBinaryValue("KEY"));
-  base::DictionaryValue* options = new base::DictionaryValue();
-  args->Append(options);
+  auto options = base::MakeUnique<base::DictionaryValue>();
   options->Set("associatedData",
                StringToBinaryValue("ASSOCIATED_DATA"));
   options->Set("verificationKeyId",
                StringToBinaryValue("VERIFICATION_KEY_ID"));
   options->SetString(
       "signType",
       api::ToString(api::SIGNATURE_TYPE_ECDSA_P256_SHA256));
+  args->Append(std::move(options));
 
   ASSERT_TRUE(extension_function_test_utils::RunFunction(
       function.get(), std::move(args), browser(),
       extension_function_test_utils::NONE));
 
   EXPECT_EQ(expected_result, GetSingleBinaryResultAsString(function.get()));
 }
 
 TEST_F(EasyUnlockPrivateApiTest, UnwrapSecureMessage) {
   scoped_refptr<EasyUnlockPrivateUnwrapSecureMessageFunction> function(
       new EasyUnlockPrivateUnwrapSecureMessageFunction());
   function->set_has_callback(true);
 
   chromeos::EasyUnlockClient::UnwrapSecureMessageOptions unwrap_options;
   unwrap_options.key = "KEY";
   unwrap_options.associated_data = "ASSOCIATED_DATA";
   unwrap_options.encryption_type = easy_unlock::kEncryptionTypeAES256CBC;
   unwrap_options.signature_type = easy_unlock::kSignatureTypeHMACSHA256;
 
   std::string expected_result;
   client_->UnwrapSecureMessage(
       "MESSAGE",
       unwrap_options,
       base::Bind(&CopyData, &expected_result));
   ASSERT_GT(expected_result.length(), 0u);
 
   std::unique_ptr<base::ListValue> args(new base::ListValue);
   args->Append(StringToBinaryValue("MESSAGE"));
   args->Append(StringToBinaryValue("KEY"));
-  base::DictionaryValue* options = new base::DictionaryValue();
-  args->Append(options);
+  auto options = base::MakeUnique<base::DictionaryValue>();
   options->Set("associatedData", StringToBinaryValue("ASSOCIATED_DATA"));
   options->SetString(
       "encryptType",
       api::ToString(api::ENCRYPTION_TYPE_AES_256_CBC));
   options->SetString(
       "signType",
       api::ToString(api::SIGNATURE_TYPE_HMAC_SHA256));
+  args->Append(std::move(options));
 
   ASSERT_TRUE(extension_function_test_utils::RunFunction(
       function.get(), std::move(args), browser(),
       extension_function_test_utils::NONE));
 
   EXPECT_EQ(expected_result, GetSingleBinaryResultAsString(function.get()));
 }
 
 TEST_F(EasyUnlockPrivateApiTest, UnwrapSecureMessage_EmptyOptions) {
   scoped_refptr<EasyUnlockPrivateUnwrapSecureMessageFunction> function(
@@ skipping 39 matching lines @@
   std::string expected_result;
   client_->UnwrapSecureMessage(
       "MESSAGE",
       unwrap_options,
       base::Bind(&CopyData, &expected_result));
   ASSERT_GT(expected_result.length(), 0u);
 
   std::unique_ptr<base::ListValue> args(new base::ListValue);
   args->Append(StringToBinaryValue("MESSAGE"));
   args->Append(StringToBinaryValue("KEY"));
-  base::DictionaryValue* options = new base::DictionaryValue();
-  args->Append(options);
+  auto options = base::MakeUnique<base::DictionaryValue>();
   options->Set("associatedData",
                StringToBinaryValue("ASSOCIATED_DATA"));
   options->SetString(
       "signType",
       api::ToString(api::SIGNATURE_TYPE_ECDSA_P256_SHA256));
+  args->Append(std::move(options));
 
   ASSERT_TRUE(extension_function_test_utils::RunFunction(
       function.get(), std::move(args), browser(),
       extension_function_test_utils::NONE));
 
   EXPECT_EQ(expected_result, GetSingleBinaryResultAsString(function.get()));
 }
 
 struct AutoPairingResult {
   AutoPairingResult() : success(false) {}
@@ skipping 190 matching lines @@
 
   scoped_refptr<TestableGetPermitAccessFunction> function(
       new TestableGetPermitAccessFunction());
   std::unique_ptr<base::Value> value(
       extensions::api_test_utils::RunFunctionAndReturnSingleResult(
           function.get(), "[]", profile()));
   EXPECT_FALSE(value);
 }
 
 }  // namespace