Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc

Issue 2416433006: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/extensions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc b/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
index 6069e1139607b093b859ebda3769102d9d944664..4f1d60f8d60fc9e52e34e75ddb73ec509911cd24 100644
--- a/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
+++ b/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
@@ -180,7 +180,7 @@ class ImeObserverChromeOS : public ui::ImeObserver {
// first composition character, so for backward compatibility, add it here.
base::Value* first_value = NULL;
if (bounds_list->Get(0, &first_value))
- args->Append(first_value->DeepCopy());
+ args->Append(first_value->CreateDeepCopy());
args->Append(std::move(bounds_list));
DispatchEventToExtension(

Powered by Google App Engine
This is Rietveld 408576698