Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2415613003: Ensure clean layout for all (but deprecated) functions creating VisiblePositions (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure clean layout for all (but deprecated) functions creating VisiblePositions This patch ensures clean layout when calling the following functions: - VisiblePosition::beforeNode - VisiblePosition::afterNode - VisiblePosition::firstPositionInNode - VisiblePosition::lastPositionInNode - VisiblePosition::inParentBeforeNode - VisiblePosition::inParentAfterNode The layout update calls in these functions become unnecessary and are removed. BUG=647219 Committed: https://crrev.com/563e8dd782f2c6ba461bde1d15591063d6a9ee62 Cr-Commit-Position: refs/heads/master@{#424967}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -33 lines) Patch
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 6 chunks +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 3 chunks +9 lines, -5 lines 1 comment Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-13 06:06:13 UTC) #6
yosin_UTC9
lgtm https://codereview.chromium.org/2415613003/diff/1/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp File third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp (right): https://codereview.chromium.org/2415613003/diff/1/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp#newcode419 third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp:419: document().updateStyleAndLayoutIgnorePendingStylesheets(); Wow, we has been updating layout in ...
4 years, 2 months ago (2016-10-13 06:26:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415613003/1
4 years, 2 months ago (2016-10-13 06:27:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 06:32:34 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 06:34:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/563e8dd782f2c6ba461bde1d15591063d6a9ee62
Cr-Commit-Position: refs/heads/master@{#424967}

Powered by Google App Engine
This is Rietveld 408576698