Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: third_party/WebKit/Source/core/editing/VisiblePosition.cpp

Issue 2415613003: Ensure clean layout for all (but deprecated) functions creating VisiblePositions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisiblePosition.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisiblePosition.cpp b/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
index 8e85aef74d1f56803bf7182e4b7ebc88ece1a114..63009d224b9879577fb06bc768731efef2134444 100644
--- a/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
+++ b/third_party/WebKit/Source/core/editing/VisiblePosition.cpp
@@ -97,11 +97,6 @@ VisiblePositionTemplate<Strategy> VisiblePositionTemplate<Strategy>::create(
template <typename Strategy>
VisiblePositionTemplate<Strategy> VisiblePositionTemplate<Strategy>::afterNode(
Node* node) {
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- if (node)
- node->document().updateStyleAndLayoutIgnorePendingStylesheets();
-
return create(PositionWithAffinityTemplate<Strategy>(
PositionTemplate<Strategy>::afterNode(node)));
}
@@ -109,11 +104,6 @@ VisiblePositionTemplate<Strategy> VisiblePositionTemplate<Strategy>::afterNode(
template <typename Strategy>
VisiblePositionTemplate<Strategy> VisiblePositionTemplate<Strategy>::beforeNode(
Node* node) {
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- if (node)
- node->document().updateStyleAndLayoutIgnorePendingStylesheets();
-
return create(PositionWithAffinityTemplate<Strategy>(
PositionTemplate<Strategy>::beforeNode(node)));
}
@@ -121,11 +111,6 @@ VisiblePositionTemplate<Strategy> VisiblePositionTemplate<Strategy>::beforeNode(
template <typename Strategy>
VisiblePositionTemplate<Strategy>
VisiblePositionTemplate<Strategy>::firstPositionInNode(Node* node) {
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- if (node)
- node->document().updateStyleAndLayoutIgnorePendingStylesheets();
-
return create(PositionWithAffinityTemplate<Strategy>(
PositionTemplate<Strategy>::firstPositionInNode(node)));
}
@@ -133,10 +118,6 @@ VisiblePositionTemplate<Strategy>::firstPositionInNode(Node* node) {
template <typename Strategy>
VisiblePositionTemplate<Strategy>
VisiblePositionTemplate<Strategy>::inParentAfterNode(const Node& node) {
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- node.document().updateStyleAndLayoutIgnorePendingStylesheets();
-
return create(PositionWithAffinityTemplate<Strategy>(
PositionTemplate<Strategy>::inParentAfterNode(node)));
}
@@ -144,10 +125,6 @@ VisiblePositionTemplate<Strategy>::inParentAfterNode(const Node& node) {
template <typename Strategy>
VisiblePositionTemplate<Strategy>
VisiblePositionTemplate<Strategy>::inParentBeforeNode(const Node& node) {
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- node.document().updateStyleAndLayoutIgnorePendingStylesheets();
-
return create(PositionWithAffinityTemplate<Strategy>(
PositionTemplate<Strategy>::inParentBeforeNode(node)));
}
@@ -155,11 +132,6 @@ VisiblePositionTemplate<Strategy>::inParentBeforeNode(const Node& node) {
template <typename Strategy>
VisiblePositionTemplate<Strategy>
VisiblePositionTemplate<Strategy>::lastPositionInNode(Node* node) {
- // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. See http://crbug.com/590369 for more details.
- if (node)
- node->document().updateStyleAndLayoutIgnorePendingStylesheets();
-
return create(PositionWithAffinityTemplate<Strategy>(
PositionTemplate<Strategy>::lastPositionInNode(node)));
}

Powered by Google App Engine
This is Rietveld 408576698