Ensure clean layout for all (but deprecated) functions creating VisiblePositions

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 609 matching lines @@
           return;
         continue;
       }
       removeElementAttribute(element, styleAttr);
     } else if (newInlineStyle->style()->propertyCount() !=
                inlineStyle->propertyCount()) {
       setNodeAttribute(element, styleAttr,
                        AtomicString(newInlineStyle->style()->asText()));
     }
 
+    document().updateStyleAndLayoutIgnorePendingStylesheets();
+
     // FIXME: Tolerate differences in id, class, and style attributes.
     if (element->parentNode() && isNonTableCellHTMLBlockElement(element) &&
         areIdenticalElements(*element, *element->parentNode()) &&
         VisiblePosition::firstPositionInNode(element->parentNode())
                 .deepEquivalent() ==
             VisiblePosition::firstPositionInNode(element).deepEquivalent() &&
         VisiblePosition::lastPositionInNode(element->parentNode())
                 .deepEquivalent() ==
             VisiblePosition::lastPositionInNode(element).deepEquivalent()) {
       insertedNodes.willRemoveNodePreservingChildren(*element);
@@ skipping 828 matching lines @@
       insertionPos.anchorNode() == enclosingBlockOfInsertionPos->parentNode() &&
       (unsigned)insertionPos.computeEditingOffset() <
           enclosingBlockOfInsertionPos->nodeIndex() &&
       !isStartOfParagraph(startOfInsertedContent)) {
     insertNodeAt(HTMLBRElement::create(document()),
                  startOfInsertedContent.deepEquivalent(), editingState);
     if (editingState->isAborted())
       return;
   }
 
+  document().updateStyleAndLayoutIgnorePendingStylesheets();
   if (endBR &&
       (plainTextFragment ||
        (shouldRemoveEndBR(endBR, originalVisPosBeforeEndBR) &&
         !(fragment.hasInterchangeNewlineAtEnd() && selectionIsPlainText)))) {
     ContainerNode* parent = endBR->parentNode();
     insertedNodes.willRemoveNode(*endBR);
     removeNode(endBR, editingState);
     if (editingState->isAborted())
       return;
     if (Node* nodeToRemove = highestNodeToRemoveInPruning(parent)) {
@@ skipping 116 matching lines @@
     if (selectionEndWasEndOfParagraph ||
         !isEndOfParagraph(endOfInsertedContent) || next.isNull()) {
       if (HTMLTextFormControlElement* textControl =
               enclosingTextFormControl(currentRoot)) {
         if (!insertedNodes.lastLeafInserted()->nextSibling()) {
           insertNodeAfter(textControl->createPlaceholderBreakElement(),
                           insertedNodes.lastLeafInserted(), editingState);
           if (editingState->isAborted())
             return;
         }
+        document().updateStyleAndLayoutIgnorePendingStylesheets();
         setEndingSelection(
             VisiblePosition::afterNode(insertedNodes.lastLeafInserted()));
         // Select up to the paragraph separator that was added.
         lastPositionToSelect =
             endingSelection().visibleStart().deepEquivalent();
       } else if (!isStartOfParagraph(endOfInsertedContent)) {
         setEndingSelection(endOfInsertedContent);
         Element* enclosingBlockElement =
             enclosingBlock(endOfInsertedContent.deepEquivalent().anchorNode());
         if (isListItem(enclosingBlockElement)) {
           HTMLLIElement* newListItem = HTMLLIElement::create(document());
           insertNodeAfter(newListItem, enclosingBlockElement, editingState);
           if (editingState->isAborted())
             return;
+          document().updateStyleAndLayoutIgnorePendingStylesheets();
           setEndingSelection(VisiblePosition::firstPositionInNode(newListItem));
         } else {
           // Use a default paragraph element (a plain div) for the empty
           // paragraph, using the last paragraph block's style seems to annoy
           // users.
           insertParagraphSeparator(
               editingState, true,
               !startIsInsideMailBlockquote &&
                   highestEnclosingNodeOfType(
                       endOfInsertedContent.deepEquivalent(),
@@ skipping 437 matching lines @@
   visitor->trace(m_startOfInsertedContent);
   visitor->trace(m_endOfInsertedContent);
   visitor->trace(m_insertionStyle);
   visitor->trace(m_documentFragment);
   visitor->trace(m_startOfInsertedRange);
   visitor->trace(m_endOfInsertedRange);
   CompositeEditCommand::trace(visitor);
 }
 
 }  // namespace blink