third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2415613003: Ensure clean layout for all (but deprecated) functions creating VisiblePositions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2415613003: Ensure clean layout for all (but deprecated) functions creating VisiblePositions (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index d51cc9fd89130dbbc415afc66306891d0b060a18..9b16ad8b03461d9d3aa4b3a398bacf613c3a16ce 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -361,6 +361,7 @@ bool InsertListCommand::doApplyForSingleParagraph(

if (editingState->isAborted())

return false;

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

Node* firstChildInList =

enclosingListChild(VisiblePosition::firstPositionInNode(listElement)

.deepEquivalent()

@@ -401,6 +402,7 @@ bool InsertListCommand::doApplyForSingleParagraph(

currentSelection.setEnd(newList, Position::lastOffsetInNode(newList),

IGNORE_EXCEPTION);

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

setEndingSelection(VisiblePosition::firstPositionInNode(newList));

return true;