Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 24153010: Pass isolate to V8EventListener constructor (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
Reviewers:
haraken, marja
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, do-not-use
Visibility:
Public.

Description

Pass isolate to V8EventListener constructor Pass isolate to V8EventListener constructor to avoid call to v8::Isolate::GetCurrent(). R=haraken BUG=263412 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158043

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8ErrorHandler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8ErrorHandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8EventListener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8EventListener.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8EventListenerList.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8EventListenerList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8WorkerGlobalScopeEventListener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-18 12:51:08 UTC) #1
haraken
LGTM
7 years, 3 months ago (2013-09-19 00:31:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/24153010/1
7 years, 3 months ago (2013-09-19 06:11:29 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/bindings/scripts/deprecated_code_generator_v8.pm: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 3 months ago (2013-09-19 06:11:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/24153010/6001
7 years, 3 months ago (2013-09-19 17:15:34 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 18:30:51 UTC) #6
Message was sent while issue was closed.
Change committed as 158043

Powered by Google App Engine
This is Rietveld 408576698