Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Side by Side Diff: Source/bindings/v8/V8ErrorHandler.cpp

Issue 24153010: Pass isolate to V8EventListener constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8ErrorHandler.h ('k') | Source/bindings/v8/V8EventListener.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 #include "bindings/v8/V8HiddenPropertyName.h" 37 #include "bindings/v8/V8HiddenPropertyName.h"
38 #include "bindings/v8/V8ScriptRunner.h" 38 #include "bindings/v8/V8ScriptRunner.h"
39 #include "core/dom/Document.h" 39 #include "core/dom/Document.h"
40 #include "core/dom/ErrorEvent.h" 40 #include "core/dom/ErrorEvent.h"
41 #include "core/dom/EventNames.h" 41 #include "core/dom/EventNames.h"
42 #include "core/dom/ScriptExecutionContext.h" 42 #include "core/dom/ScriptExecutionContext.h"
43 #include "core/page/Frame.h" 43 #include "core/page/Frame.h"
44 44
45 namespace WebCore { 45 namespace WebCore {
46 46
47 V8ErrorHandler::V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline) 47 V8ErrorHandler::V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, v8 ::Isolate* isolate)
48 : V8EventListener(listener, isInline) 48 : V8EventListener(listener, isInline, isolate)
49 { 49 {
50 } 50 }
51 51
52 v8::Local<v8::Value> V8ErrorHandler::callListenerFunction(ScriptExecutionContext * context, v8::Handle<v8::Value> jsEvent, Event* event) 52 v8::Local<v8::Value> V8ErrorHandler::callListenerFunction(ScriptExecutionContext * context, v8::Handle<v8::Value> jsEvent, Event* event)
53 { 53 {
54 if (!event->hasInterface(eventNames().interfaceForErrorEvent)) 54 if (!event->hasInterface(eventNames().interfaceForErrorEvent))
55 return V8EventListener::callListenerFunction(context, jsEvent, event); 55 return V8EventListener::callListenerFunction(context, jsEvent, event);
56 56
57 ErrorEvent* errorEvent = static_cast<ErrorEvent*>(event); 57 ErrorEvent* errorEvent = static_cast<ErrorEvent*>(event);
58 58
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 v8::Local<v8::Object>::Cast(wrappedEvent)->SetHiddenValue(V8HiddenProper tyName::error(), data); 90 v8::Local<v8::Object>::Cast(wrappedEvent)->SetHiddenValue(V8HiddenProper tyName::error(), data);
91 } 91 }
92 } 92 }
93 93
94 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue) 94 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue)
95 { 95 {
96 return returnValue->IsBoolean() && returnValue->BooleanValue(); 96 return returnValue->IsBoolean() && returnValue->BooleanValue();
97 } 97 }
98 98
99 } // namespace WebCore 99 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8ErrorHandler.h ('k') | Source/bindings/v8/V8EventListener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698