Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: Source/bindings/v8/V8ErrorHandler.h

Issue 24153010: Pass isolate to V8EventListener constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/v8/V8ErrorHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8ErrorHandler.h
diff --git a/Source/bindings/v8/V8ErrorHandler.h b/Source/bindings/v8/V8ErrorHandler.h
index 92246d3f136dc6eb163f8e173fda46e0d0dd1f90..faaf430adc2f7ce4d68af00e5a00e1eb09a9b54d 100644
--- a/Source/bindings/v8/V8ErrorHandler.h
+++ b/Source/bindings/v8/V8ErrorHandler.h
@@ -42,15 +42,15 @@ class Frame;
class V8ErrorHandler : public V8EventListener {
public:
- static PassRefPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, bool isInline)
+ static PassRefPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, bool isInline, v8::Isolate* isolate)
{
- return adoptRef(new V8ErrorHandler(listener, isInline));
+ return adoptRef(new V8ErrorHandler(listener, isInline, isolate));
}
static void storeExceptionOnErrorEventWrapper(ErrorEvent*, v8::Handle<v8::Value>, v8::Isolate*);
private:
- V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline);
+ V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, v8::Isolate*);
virtual v8::Local<v8::Value> callListenerFunction(ScriptExecutionContext*, v8::Handle<v8::Value> jsEvent, Event*);
virtual bool shouldPreventDefault(v8::Local<v8::Value> returnValue);
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/v8/V8ErrorHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698