Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 24153010: Pass isolate to V8EventListener constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/v8/V8ErrorHandler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 1896 matching lines...) Expand 10 before | Expand all | Expand 10 after
1907 # Non callable input should be treated as null 1907 # Non callable input should be treated as null
1908 $code .= " if (!value->IsNull() && !value->IsFunction())\n"; 1908 $code .= " if (!value->IsNull() && !value->IsFunction())\n";
1909 $code .= " value = v8::Null(info.GetIsolate());\n"; 1909 $code .= " value = v8::Null(info.GetIsolate());\n";
1910 if (!InheritsInterface($interface, "Node")) { 1910 if (!InheritsInterface($interface, "Node")) {
1911 my $attrImplName = GetImplName($attribute); 1911 my $attrImplName = GetImplName($attribute);
1912 $code .= " transferHiddenDependency(info.Holder(), imp->${attrImp lName}(isolatedWorldForIsolate(info.GetIsolate())), value, ${v8ClassName}::event ListenerCacheIndex, info.GetIsolate());\n"; 1912 $code .= " transferHiddenDependency(info.Holder(), imp->${attrImp lName}(isolatedWorldForIsolate(info.GetIsolate())), value, ${v8ClassName}::event ListenerCacheIndex, info.GetIsolate());\n";
1913 } 1913 }
1914 AddToImplIncludes("bindings/v8/V8EventListenerList.h"); 1914 AddToImplIncludes("bindings/v8/V8EventListenerList.h");
1915 if (($interfaceName eq "Window" or $interfaceName eq "WorkerGlobalScope" ) and $attribute->name eq "onerror") { 1915 if (($interfaceName eq "Window" or $interfaceName eq "WorkerGlobalScope" ) and $attribute->name eq "onerror") {
1916 AddToImplIncludes("bindings/v8/V8ErrorHandler.h"); 1916 AddToImplIncludes("bindings/v8/V8ErrorHandler.h");
1917 $code .= " imp->set$implSetterFunctionName(V8EventListenerList::f indOrCreateWrapper<V8ErrorHandler>(value, true), isolatedWorldForIsolate(info.Ge tIsolate()));\n"; 1917 $code .= " imp->set$implSetterFunctionName(V8EventListenerList::f indOrCreateWrapper<V8ErrorHandler>(value, true, info.GetIsolate()), isolatedWorl dForIsolate(info.GetIsolate()));\n";
1918 } else { 1918 } else {
1919 $code .= " imp->set$implSetterFunctionName(V8EventListenerList::g etEventListener(value, true, ListenerFindOrCreate), isolatedWorldForIsolate(info .GetIsolate()));\n"; 1919 $code .= " imp->set$implSetterFunctionName(V8EventListenerList::g etEventListener(value, true, ListenerFindOrCreate), isolatedWorldForIsolate(info .GetIsolate()));\n";
1920 } 1920 }
1921 } else { 1921 } else {
1922 my ($functionName, @arguments) = SetterExpression($interfaceName, $attri bute); 1922 my ($functionName, @arguments) = SetterExpression($interfaceName, $attri bute);
1923 push(@arguments, $expression); 1923 push(@arguments, $expression);
1924 push(@arguments, "es") if $useExceptions; 1924 push(@arguments, "es") if $useExceptions;
1925 if ($attribute->extendedAttributes->{"ImplementedBy"}) { 1925 if ($attribute->extendedAttributes->{"ImplementedBy"}) {
1926 my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy" }; 1926 my $implementedBy = $attribute->extendedAttributes->{"ImplementedBy" };
1927 my $implementedByImplName = GetImplNameFromImplementedBy($implemente dBy); 1927 my $implementedByImplName = GetImplNameFromImplementedBy($implemente dBy);
(...skipping 4136 matching lines...) Expand 10 before | Expand all | Expand 10 after
6064 if ($currentInterface->extendedAttributes->{$extendedAttribute}) { 6064 if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
6065 $found = 1; 6065 $found = 1;
6066 } 6066 }
6067 return 1 if $found; 6067 return 1 if $found;
6068 }, 0); 6068 }, 0);
6069 6069
6070 return $found; 6070 return $found;
6071 } 6071 }
6072 6072
6073 1; 6073 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/V8ErrorHandler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698