Replace FOR_EACH_OBSERVER in chromeos/ with range-based for

Replace FOR_EACH_OBSERVER in chromeos/ with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER chromeos/

Committed: https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368
Cr-Commit-Position: refs/heads/master@{#425461}

[Yusuke Sato, 2016-10-13 02:38:41]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 02:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 03:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 03:09:27]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-10-13 05:44:41]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 05:45:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-10-13 05:45:21]

Description was changed from

==========
Replace FOR_EACH_OBSERVER with range-based for loops

BUG=655021
TEST=try
==========

to

==========
Replace FOR_EACH_OBSERVER in chromeos/ with range-based for loops

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER chromeos/
==========

[Yusuke Sato, 2016-10-13 05:45:44]

Description was changed from

==========
Replace FOR_EACH_OBSERVER in chromeos/ with range-based for loops

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER chromeos/
==========

to

==========
Replace FOR_EACH_OBSERVER in chromeos/ with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER chromeos/
==========

[commit-bot: I haz the power, 2016-10-13 06:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 06:15:01]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-10-13 06:20:57]

yusukes@chromium.org changed reviewers:
+ derat@chromium.org

[Yusuke Sato, 2016-10-13 06:20:58]

PTAL too.

[Yusuke Sato, 2016-10-13 20:23:24]

For this one, I used the same script as
https://codereview.chromium.org/2416763002/#msg9 then manually added {}. The
diff is:

diff --git a/chromeos/audio/cras_audio_handler.cc
b/chromeos/audio/cras_audio_handler.cc
index fa74806..d75f3e3 100644
--- a/chromeos/audio/cras_audio_handler.cc
+++ b/chromeos/audio/cras_audio_handler.cc
@@ -1375,9 +1375,10 @@ void
CrasAudioHandler::UpdateAudioAfterHDMIRediscoverGracePeriod() {
     SetOutputMuteInternal(false);
 
     // Notify UI about the mute state change.
-    for (auto& observer : observers_)
+    for (auto& observer : observers_) {
       observer.OnOutputMuteChanged(output_mute_on_,
                                    true /* system adjustment */);
+    }
   }
 }
 
diff --git a/chromeos/dbus/power_manager_client.cc
b/chromeos/dbus/power_manager_client.cc
index b019b43..73d21d5 100644
--- a/chromeos/dbus/power_manager_client.cc
+++ b/chromeos/dbus/power_manager_client.cc
@@ -626,9 +626,10 @@ class PowerManagerClientImpl : public PowerManagerClient {
                        << power_manager::kIdleActionImminentSignal << "
signal";
       return;
     }
-    for (auto& observer : observers_)
+    for (auto& observer : observers_) {
       observer.IdleActionImminent(
           base::TimeDelta::FromInternalValue(proto.time_until_idle_action()));
+    }
   }
 
   void IdleActionDeferredReceived(dbus::Signal* signal) {
diff --git a/chromeos/network/network_configuration_handler.cc
b/chromeos/network/network_configuration_handler.cc
index 7dc7f4b..03bf1fb 100644
--- a/chromeos/network/network_configuration_handler.cc
+++ b/chromeos/network/network_configuration_handler.cc
@@ -401,9 +401,10 @@ void NetworkConfigurationHandler::RunCreateNetworkCallback(
     DCHECK(!guid.empty());
     callback.Run(service_path.value(), guid);
   }
-  for (auto& observer : observers_)
+  for (auto& observer : observers_) {
     observer.OnConfigurationCreated(service_path.value(), profile_path,
                                     *configure_properties, source);
+  }
   // This may also get called when CreateConfiguration is used to update an
   // existing configuration, so request a service update just in case.
   // TODO(pneubeck): Separate 'Create' and 'Update' calls and only trigger
@@ -487,9 +488,10 @@ void
NetworkConfigurationHandler::SetPropertiesSuccessCallback(
   if (!network_state)
     return;  // Network no longer exists, do not notify or request update.
 
-  for (auto& observer : observers_)
+  for (auto& observer : observers_) {
     observer.OnPropertiesSet(service_path, network_state->guid(),
                              *set_properties, source);
+  }
   network_state_handler_->RequestUpdateForNetwork(service_path);
 }

[Daniel Erat, 2016-10-13 20:35:43]

lgtm

[Yusuke Sato, 2016-10-13 20:58:35]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:59:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:10:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yusuke Sato, 2016-10-13 21:18:54]

yusukes@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Yusuke Sato, 2016-10-13 21:18:54]

+stevenjb@. Could you have a look at chromeos/network/?

[Yusuke Sato, 2016-10-14 19:47:13]

On 2016/10/13 21:18:54, Yusuke Sato wrote:
> +stevenjb@. Could you have a look at chromeos/network/?

fyi, this is done by the following script:

cd chromeos/ && perl -0777 -pi -e
's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+)\);/for (auto&
observer : \2) observer.\3;/mg' $(git gs FOR_EACH_OBSERVER | cut -d: -f1 | uniq)
&& git cl format

and then I added {}s to multi-line for loops as shown in #13.

[stevenjb, 2016-10-14 20:02:06]

chromeos/network lgtm

[Yusuke Sato, 2016-10-14 20:02:45]

thanks!

[Yusuke Sato, 2016-10-14 20:02:53]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-10-14 20:03:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 20:57:21]

Description was changed from

==========
Replace FOR_EACH_OBSERVER in chromeos/ with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER chromeos/
==========

to

==========
Replace FOR_EACH_OBSERVER in chromeos/ with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER chromeos/
==========

[commit-bot: I haz the power, 2016-10-14 20:57:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-14 20:59:09]

Description was changed from

==========
Replace FOR_EACH_OBSERVER in chromeos/ with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER chromeos/
==========

to

==========
Replace FOR_EACH_OBSERVER in chromeos/ with range-based for

BUG=655021
TEST=try, git grep FOR_EACH_OBSERVER chromeos/

Committed: https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368
Cr-Commit-Position: refs/heads/master@{#425461}
==========

[commit-bot: I haz the power, 2016-10-14 20:59:10]

Patchset 2 (id:??) landed as
https://crrev.com/262cf7e2ec101f26d00da06958854f85c4cca368
Cr-Commit-Position: refs/heads/master@{#425461}