Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: chromeos/network/network_sms_handler.cc

Issue 2413963002: Replace FOR_EACH_OBSERVER in chromeos/ with range-based for (Closed)
Patch Set: Run the script again with '/mg' Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/network/network_profile_handler.cc ('k') | chromeos/network/network_state_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/network_sms_handler.h" 5 #include "chromeos/network/network_sms_handler.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 385
386 void NetworkSmsHandler::AddReceivedMessage( 386 void NetworkSmsHandler::AddReceivedMessage(
387 const base::DictionaryValue& message) { 387 const base::DictionaryValue& message) {
388 if (received_messages_.size() >= kMaxReceivedMessages) 388 if (received_messages_.size() >= kMaxReceivedMessages)
389 received_messages_.erase(received_messages_.begin()); 389 received_messages_.erase(received_messages_.begin());
390 received_messages_.push_back(message.CreateDeepCopy()); 390 received_messages_.push_back(message.CreateDeepCopy());
391 } 391 }
392 392
393 void NetworkSmsHandler::NotifyMessageReceived( 393 void NetworkSmsHandler::NotifyMessageReceived(
394 const base::DictionaryValue& message) { 394 const base::DictionaryValue& message) {
395 FOR_EACH_OBSERVER(Observer, observers_, MessageReceived(message)); 395 for (auto& observer : observers_)
396 observer.MessageReceived(message);
396 } 397 }
397 398
398 void NetworkSmsHandler::MessageReceived(const base::DictionaryValue& message) { 399 void NetworkSmsHandler::MessageReceived(const base::DictionaryValue& message) {
399 AddReceivedMessage(message); 400 AddReceivedMessage(message);
400 NotifyMessageReceived(message); 401 NotifyMessageReceived(message);
401 } 402 }
402 403
403 void NetworkSmsHandler::ManagerPropertiesCallback( 404 void NetworkSmsHandler::ManagerPropertiesCallback(
404 DBusMethodCallStatus call_status, 405 DBusMethodCallStatus call_status,
405 const base::DictionaryValue& properties) { 406 const base::DictionaryValue& properties) {
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 base::MakeUnique<ModemManager1NetworkSmsDeviceHandler>( 474 base::MakeUnique<ModemManager1NetworkSmsDeviceHandler>(
474 this, service_name, object_path)); 475 this, service_name, object_path));
475 } else { 476 } else {
476 device_handlers_.push_back( 477 device_handlers_.push_back(
477 base::MakeUnique<ModemManagerNetworkSmsDeviceHandler>( 478 base::MakeUnique<ModemManagerNetworkSmsDeviceHandler>(
478 this, service_name, object_path)); 479 this, service_name, object_path));
479 } 480 }
480 } 481 }
481 482
482 } // namespace chromeos 483 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/network/network_profile_handler.cc ('k') | chromeos/network/network_state_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698