Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8956)

Unified Diff: chromeos/dbus/update_engine_client.cc

Issue 2413963002: Replace FOR_EACH_OBSERVER in chromeos/ with range-based for (Closed)
Patch Set: Run the script again with '/mg' Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/system_clock_client.cc ('k') | chromeos/disks/disk_mount_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/update_engine_client.cc
diff --git a/chromeos/dbus/update_engine_client.cc b/chromeos/dbus/update_engine_client.cc
index 0bd247ae1682faf23f45ff472695359fc6499275..d772d0074513b7cbf9ddf6cd6ab55430c37faf95 100644
--- a/chromeos/dbus/update_engine_client.cc
+++ b/chromeos/dbus/update_engine_client.cc
@@ -328,7 +328,8 @@ class UpdateEngineClientImpl : public UpdateEngineClient {
}
status.status = UpdateStatusFromString(current_operation);
last_status_ = status;
- FOR_EACH_OBSERVER(Observer, observers_, UpdateStatusChanged(status));
+ for (auto& observer : observers_)
+ observer.UpdateStatusChanged(status);
}
// Called when GetStatus call failed.
@@ -419,7 +420,8 @@ class UpdateEngineClientImpl : public UpdateEngineClient {
status.new_size = new_size;
last_status_ = status;
- FOR_EACH_OBSERVER(Observer, observers_, UpdateStatusChanged(status));
+ for (auto& observer : observers_)
+ observer.UpdateStatusChanged(status);
}
// Called when the status update signal is initially connected.
@@ -566,7 +568,8 @@ class UpdateEngineClientFakeImpl : public UpdateEngineClientStubImpl {
break;
}
last_status_.status = next_status;
- FOR_EACH_OBSERVER(Observer, observers_, UpdateStatusChanged(last_status_));
+ for (auto& observer : observers_)
+ observer.UpdateStatusChanged(last_status_);
if (last_status_.status != UPDATE_STATUS_IDLE) {
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE, base::Bind(&UpdateEngineClientFakeImpl::StateTransition,
« no previous file with comments | « chromeos/dbus/system_clock_client.cc ('k') | chromeos/disks/disk_mount_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698