chromeos/dbus/fake_shill_service_client.cc - Issue 2413963002: Replace FOR_EACH_OBSERVER in chromeos/ with range-based for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_service_client.cc

Issue 2413963002: Replace FOR_EACH_OBSERVER in chromeos/ with range-based for (Closed)

Patch Set: Run the script again with '/mg' Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/fake_shill_service_client.cc

diff --git a/chromeos/dbus/fake_shill_service_client.cc b/chromeos/dbus/fake_shill_service_client.cc

index cbbcc5cafe5b0a00f59ae9fc7e5497b0841f327e..33a8169742ce2d6c4b17a45e0e87900f4cb9b810 100644

--- a/chromeos/dbus/fake_shill_service_client.cc

+++ b/chromeos/dbus/fake_shill_service_client.cc

@@ -521,9 +521,8 @@ void FakeShillServiceClient::NotifyObserversPropertyChanged(

<< path << " : " << property;

return;

}

- FOR_EACH_OBSERVER(ShillPropertyChangedObserver,

- GetObserverList(service_path),

- OnPropertyChanged(property, *value));

+ for (auto& observer : GetObserverList(service_path))

+ observer.OnPropertyChanged(property, *value);

}

base::DictionaryValue* FakeShillServiceClient::GetModifiableServiceProperties(