Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)

Created:
4 years, 2 months ago by Shanmuga Pandi
Modified:
4 years, 1 month ago
CC:
android-webview-reviews_chromium.org, blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. spec: https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement BUG=596043 Committed: https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f Cr-Commit-Position: refs/heads/master@{#427992}

Patch Set 1 #

Patch Set 2 : Added more tests #

Patch Set 3 : nits #

Total comments: 29

Patch Set 4 : Align with review comments #

Total comments: 23

Patch Set 5 : Align with review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -132 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-attached.html View 1 2 3 4 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-detached.html View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getTotalLength-attached.html View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getTotalLength-detached.html View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-valid-arguments.html View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/path-pointAtLength.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/path-pointAtLength-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/path-totalLength.html View 1 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/path-totalLength-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/path-pointAtLength.js View 1 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/path-totalLength.js View 1 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGPathElement-valid-arguments.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dynamic-updates/SVGPathElement-valid-arguments-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGeometryElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGeometryElement.idl View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathElement.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 35 (15 generated)
Shanmuga Pandi
PTAL!!
4 years, 2 months ago (2016-10-13 07:31:16 UTC) #3
Stephen Chennney
The spec does not remove the getTotalLength or getPointAtLength functions from SVGPathElement. See https://svgwg.org/specs/paths/ It's ...
4 years, 2 months ago (2016-10-13 14:23:20 UTC) #5
fs
On 2016/10/13 at 14:23:20, schenney wrote: > The spec does not remove the getTotalLength or ...
4 years, 2 months ago (2016-10-13 14:58:44 UTC) #6
Stephen Chennney
On 2016/10/13 14:58:44, fs wrote: > On 2016/10/13 at 14:23:20, schenney wrote: > > The ...
4 years, 2 months ago (2016-10-13 15:17:51 UTC) #7
Shanmuga Pandi
On 2016/10/13 15:17:51, Stephen Chennney wrote: > On 2016/10/13 14:58:44, fs wrote: > > On ...
4 years, 2 months ago (2016-10-14 05:12:54 UTC) #8
Shanmuga Pandi
PTAL
4 years, 1 month ago (2016-10-24 09:00:17 UTC) #10
fs
Please tidy up/fix spelling in subject+description ("getTotolLength"; line-wrapped first line) https://codereview.chromium.org/2413753004/diff/40001/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt File third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt (right): https://codereview.chromium.org/2413753004/diff/40001/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt#newcode1404 ...
4 years, 1 month ago (2016-10-24 10:48:53 UTC) #11
Shanmuga Pandi
https://codereview.chromium.org/2413753004/diff/40001/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt File third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt (right): https://codereview.chromium.org/2413753004/diff/40001/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt#newcode1404 third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt:1404: FAIL SVGPathElement interface: operation getTotalLength() assert_own_property: interface prototype object ...
4 years, 1 month ago (2016-10-26 09:52:12 UTC) #12
fs
LGTM w/ nits Please also fix up the subject (missing space) and description (proper git ...
4 years, 1 month ago (2016-10-26 11:00:04 UTC) #15
foolip
https://codereview.chromium.org/2413753004/diff/60001/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt File third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt (right): https://codereview.chromium.org/2413753004/diff/60001/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt#newcode1404 third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt:1404: FAIL SVGPathElement interface: operation getTotalLength() assert_own_property: interface prototype object ...
4 years, 1 month ago (2016-10-26 11:05:22 UTC) #16
foolip
https://codereview.chromium.org/2413753004/diff/60001/third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt File third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt (right): https://codereview.chromium.org/2413753004/diff/60001/third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt#newcode34 third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt:34: PASS SVGPathElement.prototype.getPointAtLength must be moved to SVGGeometryElement.prototype Yay. https://codereview.chromium.org/2413753004/diff/60001/third_party/WebKit/LayoutTests/imported/wpt/svg/interfaces-expected.txt ...
4 years, 1 month ago (2016-10-26 11:12:15 UTC) #17
Shanmuga Pandi
https://codereview.chromium.org/2413753004/diff/60001/third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt File third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt (right): https://codereview.chromium.org/2413753004/diff/60001/third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt#newcode34 third_party/WebKit/LayoutTests/imported/wpt/svg/historical-expected.txt:34: PASS SVGPathElement.prototype.getPointAtLength must be moved to SVGGeometryElement.prototype On 2016/10/26 ...
4 years, 1 month ago (2016-10-26 11:28:28 UTC) #19
foolip
webexposed changes lgtm
4 years, 1 month ago (2016-10-26 11:33:37 UTC) #20
Shanmuga Pandi
timvolodine@chromium.org: Please review changes in android_webview
4 years, 1 month ago (2016-10-26 11:41:38 UTC) #22
timvolodine
android_webview/.. lgtm
4 years, 1 month ago (2016-10-26 18:01:30 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413753004/80001
4 years, 1 month ago (2016-10-27 05:33:23 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/56543)
4 years, 1 month ago (2016-10-27 06:47:53 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413753004/80001
4 years, 1 month ago (2016-10-27 09:05:22 UTC) #31
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-27 10:25:48 UTC) #33
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 10:27:40 UTC) #35
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/887bbf6c0edcabfa012099379c2d68a3dc4afd3f
Cr-Commit-Position: refs/heads/master@{#427992}

Powered by Google App Engine
This is Rietveld 408576698