third_party/WebKit/Source/core/svg/SVGGeometryElement.h - Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGGeometryElement.h

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)

Patch Set: Align with review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGGeometryElement.h

diff --git a/third_party/WebKit/Source/core/svg/SVGGeometryElement.h b/third_party/WebKit/Source/core/svg/SVGGeometryElement.h

index 89b15ba32e26fa66df6b077f9e1078d25c601811..9c98508d7e33b4553e7237eb7a685b1f47799114 100644

--- a/third_party/WebKit/Source/core/svg/SVGGeometryElement.h

+++ b/third_party/WebKit/Source/core/svg/SVGGeometryElement.h

@@ -48,6 +48,8 @@ class SVGGeometryElement : public SVGGraphicsElement {

void toClipPath(Path&) const;

LayoutObject* createLayoutObject(const ComputedStyle&) override;

+ virtual float getTotalLength();

+ virtual SVGPointTearOff* getPointAtLength(float distance);

protected:

SVGGeometryElement(const QualifiedName&,