Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGPathElement.h

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)
Patch Set: Align with review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 22 matching lines...) Expand all
33 33
34 class SVGPathElement final : public SVGGeometryElement { 34 class SVGPathElement final : public SVGGeometryElement {
35 DEFINE_WRAPPERTYPEINFO(); 35 DEFINE_WRAPPERTYPEINFO();
36 36
37 public: 37 public:
38 DECLARE_NODE_FACTORY(SVGPathElement); 38 DECLARE_NODE_FACTORY(SVGPathElement);
39 39
40 Path asPath() const override; 40 Path asPath() const override;
41 Path attributePath() const; 41 Path attributePath() const;
42 42
43 float getTotalLength(); 43 float getTotalLength() override;
44 SVGPointTearOff* getPointAtLength(float distance); 44 SVGPointTearOff* getPointAtLength(float distance) override;
45 unsigned getPathSegAtLength(float distance); 45 unsigned getPathSegAtLength(float distance);
46 46
47 SVGAnimatedPath* path() const { return m_path.get(); } 47 SVGAnimatedPath* path() const { return m_path.get(); }
48 SVGAnimatedNumber* pathLength() const { return m_pathLength.get(); } 48 SVGAnimatedNumber* pathLength() const { return m_pathLength.get(); }
49 float pathLengthScaleFactor() const; 49 float pathLengthScaleFactor() const;
50 const SVGPathByteStream& pathByteStream() const { 50 const SVGPathByteStream& pathByteStream() const {
51 return stylePath()->byteStream(); 51 return stylePath()->byteStream();
52 } 52 }
53 53
54 bool isPresentationAttribute(const QualifiedName&) const override; 54 bool isPresentationAttribute(const QualifiedName&) const override;
(...skipping 19 matching lines...) Expand all
74 74
75 void invalidateMPathDependencies(); 75 void invalidateMPathDependencies();
76 76
77 Member<SVGAnimatedNumber> m_pathLength; 77 Member<SVGAnimatedNumber> m_pathLength;
78 Member<SVGAnimatedPath> m_path; 78 Member<SVGAnimatedPath> m_path;
79 }; 79 };
80 80
81 } // namespace blink 81 } // namespace blink
82 82
83 #endif // SVGPathElement_h 83 #endif // SVGPathElement_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGGeometryElement.idl ('k') | third_party/WebKit/Source/core/svg/SVGPathElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698