third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-detached.html - Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-detached.html

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)

Patch Set: Align with review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-attached.html ('K') | « third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-attached.html ('k') | third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getTotalLength-attached.html » ('j') | third_party/WebKit/Source/core/svg/SVGGeometryElement.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>SVGGeometryElement.getPointAtLength method (element detached)</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6 test(function() {

	7 var pathElement = document.createElementNS("http://www.w3.org/2000/svg", "path ");

	8

	9 function pointAtLength(string) {

	10 pathElement.setAttribute("d", string);

	11

	12 var point = pathElement.getPointAtLength(700);

	13 return [Math.round(point.x), Math.round(point.y)];

	14 }

	15

	16 assert_array_equals(pointAtLength('M0,20 L400,20 L640,20'), [640, 20]);

	17 assert_array_equals(pointAtLength('M0,20 L400,20 L640,20 z'), [580, 20]);

	18 assert_array_equals(pointAtLength('M0,20 L400,20 z M 320,20 L640,20'), [100, 2 0]);

	19 assert_array_equals(pointAtLength('M0,20 L20,40'), [20, 40]);

	20 }, document.title + " with SVGPathElement");

	21

	22 test(function() {

	23 var rectElement = document.createElementNS("http://www.w3.org/2000/svg", "rect ");

	24

	25 function pointAtLength(rx, ry, width, height) {

	26 rectElement.setAttribute("rx", rx);

	27 rectElement.setAttribute("ry", ry);

	28 rectElement.setAttribute("width", width);

	29 rectElement.setAttribute("height", height);

	30

	31 var point = rectElement.getPointAtLength(300);

	32 return [Math.round(point.x), Math.round(point.y)];

	33 }

	34

	35 assert_array_equals(pointAtLength('0', '0', '200', '300'), [0, 0]);
	fs 2016/10/26 11:00:04 Nit: Same as in -attached.html Nit: Same as in -attached.html Shanmuga Pandi 2016/10/26 11:28:28 Done. Show quoted text On 2016/10/26 11:00:04, fs wrote: > Nit: Same as in -attached.html Done.
	36 assert_array_equals(pointAtLength('50', '50', '200', '300'), [0, 0]);

	37 }, document.title + " with SVGRectElement");

	38

	39 test(function() {

	40 var circleElement = document.createElementNS("http://www.w3.org/2000/svg", "ci rcle");

	41

	42 function pointAtLength(string) {
	fs 2016/10/26 11:00:04 Nit: Same as in -attached.html Nit: Same as in -attached.html Shanmuga Pandi 2016/10/26 11:28:28 Done. Show quoted text On 2016/10/26 11:00:04, fs wrote: > Nit: Same as in -attached.html Done.
	43 circleElement.setAttribute("r", string);

	44

	45 var point = circleElement.getPointAtLength(100);

	46 return [Math.round(point.x), Math.round(point.y)];

	47 }

	48

	49 assert_array_equals(pointAtLength('10'), [0, 0]);
	fs 2016/10/26 11:00:04 Nit: Same as in -attached.html Nit: Same as in -attached.html Shanmuga Pandi 2016/10/26 11:28:28 Done. Show quoted text On 2016/10/26 11:00:04, fs wrote: > Nit: Same as in -attached.html Done.
	50 assert_array_equals(pointAtLength('100'), [0, 0]);

	51 }, document.title + " with SVGCircleElement");

	52 </script>

OLD	NEW