Start cleaning up the HTML tests.

Start cleaning up the HTML tests.

My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.

Changes:

- Add a "minitest" package. This shims just enough of the unittest/test
  API to make it easy to swap it out for unittest without having to
  rework the entire test.

- Go through the HTML tests from A-J and change them to use minitest
  when possible. The ones that aren't possible use asynchrony.
  Minitest doesn't support async tests (yet, maybe).

- Triage those tests and enable ones that are passing. Mark them failing
  if failing. Filed a couple of tracking bugs for the common issues,
  but for other cases, I just left a comment.

- In the process of this, I went ahead and make some of the affected
  tests strong mode clean if they weren't already and it was easy.

- Synchronize changes between dev_compiler's fork of expect and
  pkg/expect. We'll want to unfork those at some point. D-:

This gets dev_compiler from 1985 tests to 2042.

R=jacobr@google.com, vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/23058653657aa38fad84b19d35afed81f28e53bf

[Bob Nystrom, 2016-10-12 22:14:35]

rnystrom@google.com changed reviewers:
+ jacobr@google.com, vsm@google.com

[Bob Nystrom, 2016-10-12 22:14:37]

https://codereview.chromium.org/2413073002/diff/1/pkg/expect/lib/expect.dart
File pkg/expect/lib/expect.dart (right):

https://codereview.chromium.org/2413073002/diff/1/pkg/expect/lib/expect.dart#...
pkg/expect/lib/expect.dart:1: // Copyright (c) 2012, the Dart project authors. 
Please see the AUTHORS file
The changes in this file just make it bitwise identical to
pkg/dev_compiler/test/expect.dart.

[vsm, 2016-10-12 22:29:46]

lgtm!

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/tool/build...
File pkg/dev_compiler/tool/build_test_pkgs.sh (right):

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/tool/build...
pkg/dev_compiler/tool/build_test_pkgs.sh:11:
--url-mapping=package:expect/expect.dart,test/codegen/expect.dart \
Do we still need this url-mapping?  I think we might just pick up the 'real'
package now - if so, you can also delete our local copy.

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/tool/build...
pkg/dev_compiler/tool/build_test_pkgs.sh:15:
--url-mapping=package:async_helper/async_helper.dart,test/codegen/async_helper.dart
\
This too actually.

[Jacob, 2016-10-12 22:38:31]

lgtm

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/test/codeg...
File pkg/dev_compiler/test/codegen/lib/html/cross_frame_test.dart (right):

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/test/codeg...
pkg/dev_compiler/test/codegen/lib/html/cross_frame_test.dart:14: final iframe =
new IFrameElement();
why did this line change? Both new Element.tag and new IFrameElement() should
work.

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/test/codeg...
File pkg/dev_compiler/test/codegen/lib/html/css_rule_list_test.dart (right):

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/test/codeg...
pkg/dev_compiler/test/codegen/lib/html/css_rule_list_test.dart:10: var sheet =
document.styleSheets[0] as CssStyleSheet;
casting to CssStyleSheet shouldn't be required.

https://api.dartlang.org/stable/1.20.0/dart-html/HtmlDocument/styleSheets.html

[Bob Nystrom, 2016-10-13 00:12:12]

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/test/codeg...
File pkg/dev_compiler/test/codegen/lib/html/cross_frame_test.dart (right):

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/test/codeg...
pkg/dev_compiler/test/codegen/lib/html/cross_frame_test.dart:14: final iframe =
new IFrameElement();
On 2016/10/12 22:38:31, Jacob wrote:
> why did this line change? Both new Element.tag and new IFrameElement() should
> work.

Strong mode doesn't do the magical type propagation that analyzer does for new
Element.tag(), and the hope is to remove it for 2.0.

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/test/codeg...
File pkg/dev_compiler/test/codegen/lib/html/css_rule_list_test.dart (right):

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/test/codeg...
pkg/dev_compiler/test/codegen/lib/html/css_rule_list_test.dart:10: var sheet =
document.styleSheets[0] as CssStyleSheet;
On 2016/10/12 22:38:31, Jacob wrote:
> casting to CssStyleSheet shouldn't be required.
> 
> https://api.dartlang.org/stable/1.20.0/dart-html/HtmlDocument/styleSheets.html

".styleSheets" returns a List<StyleSheet>, not List<CssStyleSheet>, so we have
to downcast. (Not that there is any other kind of stylesheet in the web...)

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/tool/build...
File pkg/dev_compiler/tool/build_test_pkgs.sh (right):

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/tool/build...
pkg/dev_compiler/tool/build_test_pkgs.sh:11:
--url-mapping=package:expect/expect.dart,test/codegen/expect.dart \
On 2016/10/12 22:29:46, vsm wrote:
> Do we still need this url-mapping?  I think we might just pick up the 'real'
> package now - if so, you can also delete our local copy.

Ah, nice. Done.

https://codereview.chromium.org/2413073002/diff/1/pkg/dev_compiler/tool/build...
pkg/dev_compiler/tool/build_test_pkgs.sh:15:
--url-mapping=package:async_helper/async_helper.dart,test/codegen/async_helper.dart
\
On 2016/10/12 22:29:46, vsm wrote:
> This too actually.

It looks like dev_compiler's version of async_helper is a little different from
the pkg/async_helper one. The latter is doing something with a ReceivePort. If
it's OK with you, I'll put off unforking them for now.

[Jacob, 2016-10-13 00:22:59]

lgtm

[Bob Nystrom, 2016-10-13 15:47:30]

Description was changed from

==========
Start cleaning up the HTML tests.

My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.

Changes:

- Add a "minitest" package. This shims just enough of the unittest/test
  API to make it easy to swap it out for unittest without having to
  rework the entire test.

- Go through the HTML tests from A-J and change them to use minitest
  when possible. The ones that aren't possible use asynchrony.
  Minitest doesn't support async tests (yet, maybe).

- Triage those tests and enable ones that are passing. Mark them failing
  if failing. Filed a couple of tracking bugs for the common issues,
  but for other cases, I just left a comment.

- In the process of this, I went ahead and make some of the affected
  tests strong mode clean if they weren't already and it was easy.

- Synchronize changes between dev_compiler's fork of expect and
  pkg/expect. We'll want to unfork those at some point. D-:

This gets dev_compiler from 1985 tests to 2042.
==========

to

==========
Start cleaning up the HTML tests.

My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.

Changes:

- Add a "minitest" package. This shims just enough of the unittest/test
  API to make it easy to swap it out for unittest without having to
  rework the entire test.

- Go through the HTML tests from A-J and change them to use minitest
  when possible. The ones that aren't possible use asynchrony.
  Minitest doesn't support async tests (yet, maybe).

- Triage those tests and enable ones that are passing. Mark them failing
  if failing. Filed a couple of tracking bugs for the common issues,
  but for other cases, I just left a comment.

- In the process of this, I went ahead and make some of the affected
  tests strong mode clean if they weren't already and it was easy.

- Synchronize changes between dev_compiler's fork of expect and
  pkg/expect. We'll want to unfork those at some point. D-:

This gets dev_compiler from 1985 tests to 2042.

R=jacobr@google.com, vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/23058653657aa38fad84b19d35af...
==========

[Bob Nystrom, 2016-10-13 15:47:32]

Committed patchset #2 (id:20001) manually as
23058653657aa38fad84b19d35afed81f28e53bf (presubmit successful).