Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: pkg/dev_compiler/test/codegen/lib/html/hidden_dom_2_test.dart

Issue 2413073002: Start cleaning up the HTML tests. (Closed)
Patch Set: Unfork expect.dart. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 library HiddenDom2Test;
2 import 'package:unittest/unittest.dart';
3 import 'package:unittest/html_config.dart';
4 import 'dart:html'; 1 import 'dart:html';
5 2
3 import 'package:minitest/minitest.dart';
4
6 // Test that the dart:html API does not leak native jsdom methods: 5 // Test that the dart:html API does not leak native jsdom methods:
7 // appendChild operation. 6 // appendChild operation.
8 7
9 main() { 8 main() {
10 useHtmlConfiguration();
11
12 test('test1', () { 9 test('test1', () {
13 document.body.children.add(new Element.html(r''' 10 document.body.children.add(new Element.html(r'''
14 <div id='div1'> 11 <div id='div1'>
15 Hello World! 12 Hello World!
16 </div>''')); 13 </div>'''));
17 Element e = document.query('#div1'); 14 Element e = document.query('#div1');
18 Element e2 = new Element.html(r"<div id='xx'>XX</div>"); 15 Element e2 = new Element.html(r"<div id='xx'>XX</div>");
19 expect(e, isNotNull); 16 expect(e, isNotNull);
20 17
21 checkNoSuchMethod(() { confuse(e).appendChild(e2); }); 18 expect(() { confuse(e).appendChild(e2); }, throwsNoSuchMethodError);
22 19
23 }); 20 });
24 } 21 }
25 22
26 class Decoy { 23 class Decoy {
27 void appendChild(x) { throw 'dead code'; } 24 void appendChild(x) { throw 'dead code'; }
28 } 25 }
29 26
30 confuse(x) => opaqueTrue() ? x : (opaqueTrue() ? new Object() : new Decoy()); 27 confuse(x) => opaqueTrue() ? x : (opaqueTrue() ? new Object() : new Decoy());
31 28
32 /** Returns [:true:], but in a way that confuses the compiler. */ 29 /** Returns `true`, but in a way that confuses the compiler. */
33 opaqueTrue() => true; // Expand as needed. 30 opaqueTrue() => true; // Expand as needed.
34
35 checkNoSuchMethod(action()) {
36 var ex = null;
37 bool threw = false;
38 try {
39 action();
40 } catch (e) {
41 threw = true;
42 ex = e;
43 }
44 if (!threw)
45 expect(false, isTrue, reason: 'Action should have thrown exception');
46
47 expect(ex, isNoSuchMethodError);
48 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698