Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: pkg/dev_compiler/test/codegen/lib/html/hidden_dom_2_test.dart

Issue 2413073002: Start cleaning up the HTML tests. (Closed)
Patch Set: Unfork expect.dart. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen/lib/html/hidden_dom_2_test.dart
diff --git a/pkg/dev_compiler/test/codegen/lib/html/hidden_dom_2_test.dart b/pkg/dev_compiler/test/codegen/lib/html/hidden_dom_2_test.dart
index e8abc4eee6192db3aeb01a7d882ff5d52857ff4e..7eaf8e1bce62451b532610a06ee25c8dfaa4c6ef 100644
--- a/pkg/dev_compiler/test/codegen/lib/html/hidden_dom_2_test.dart
+++ b/pkg/dev_compiler/test/codegen/lib/html/hidden_dom_2_test.dart
@@ -1,14 +1,11 @@
-library HiddenDom2Test;
-import 'package:unittest/unittest.dart';
-import 'package:unittest/html_config.dart';
import 'dart:html';
+import 'package:minitest/minitest.dart';
+
// Test that the dart:html API does not leak native jsdom methods:
// appendChild operation.
main() {
- useHtmlConfiguration();
-
test('test1', () {
document.body.children.add(new Element.html(r'''
<div id='div1'>
@@ -18,7 +15,7 @@ Hello World!
Element e2 = new Element.html(r"<div id='xx'>XX</div>");
expect(e, isNotNull);
- checkNoSuchMethod(() { confuse(e).appendChild(e2); });
+ expect(() { confuse(e).appendChild(e2); }, throwsNoSuchMethodError);
});
}
@@ -29,20 +26,5 @@ class Decoy {
confuse(x) => opaqueTrue() ? x : (opaqueTrue() ? new Object() : new Decoy());
-/** Returns [:true:], but in a way that confuses the compiler. */
+/** Returns `true`, but in a way that confuses the compiler. */
opaqueTrue() => true; // Expand as needed.
-
-checkNoSuchMethod(action()) {
- var ex = null;
- bool threw = false;
- try {
- action();
- } catch (e) {
- threw = true;
- ex = e;
- }
- if (!threw)
- expect(false, isTrue, reason: 'Action should have thrown exception');
-
- expect(ex, isNoSuchMethodError);
-}

Powered by Google App Engine
This is Rietveld 408576698