Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: pkg/dev_compiler/test/codegen/lib/html/js_typed_interop_test.dart

Issue 2413073002: Start cleaning up the HTML tests. (Closed)
Patch Set: Unfork expect.dart. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/test/codegen/lib/html/js_typed_interop_test.dart
diff --git a/pkg/dev_compiler/test/codegen/lib/html/js_typed_interop_test.dart b/pkg/dev_compiler/test/codegen/lib/html/js_typed_interop_test.dart
index f0b993867712f004cf898de2c7ca4b2622c147d5..42577f9b55d18f7ef93d9b7da57ecff24db19296 100644
--- a/pkg/dev_compiler/test/codegen/lib/html/js_typed_interop_test.dart
+++ b/pkg/dev_compiler/test/codegen/lib/html/js_typed_interop_test.dart
@@ -8,9 +8,7 @@ library js_typed_interop_test;
import 'dart:html';
import 'package:js/js.dart';
-import 'package:unittest/unittest.dart';
-import 'package:unittest/html_config.dart';
-import 'package:unittest/html_individual_config.dart';
+import 'package:minitest/minitest.dart';
_injectJs() {
document.body.append(new ScriptElement()
@@ -202,8 +200,6 @@ external num get propertyOnWindow;
main() {
_injectJs();
- useHtmlIndividualConfiguration();
-
group('object literal', () {
test('simple', () {
var l = new ExampleLiteral(x: 3, y: "foo");
@@ -274,7 +270,7 @@ main() {
Function multiplyByX = foo.multiplyByX;
// Tearing off a JS closure doesn't bind this.
// You will need to use the new method tearoff syntax to bind this.
- expect(multiplyByX(4), isNaN);
+ expect(multiplyByX(4), double.NAN);
MultiplyWithDefault multiplyWithDefault = foo.multiplyDefault2Function;
expect(multiplyWithDefault(6, 6), equals(36));
@@ -288,7 +284,7 @@ main() {
// Calling a JavaScript method with too few arguments is also fine and
// defaults to JavaScript behavior of setting all unspecified arguments
// to undefined resulting in multiplying undefined by 2 == NAN.
- expect(untypedFunction(), isNaN);
+ expect(untypedFunction(), double.NAN);
});
});

Powered by Google App Engine
This is Rietveld 408576698