Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24130008: Rename ENABLE(RUBBER_BANDING) to USE(RUBBER_BANDING). (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, kenneth.christiansen, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, dstockwell, Timothy Loh, dino_apple.com, jchaffraix+rendering, darktears, Steve Block, jeez, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename ENABLE(RUBBER_BANDING) to USE(RUBBER_BANDING) and set it in config.h instead of the gyp build system. BUG=286578 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -35 lines) Patch
M Source/config.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/features.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/page/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameView.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/ScrollView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/ScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ScrollbarTheme.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/mac/ScrollAnimatorMac.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/mac/ScrollAnimatorMac.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/mac/ScrollElasticityController.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/mac/ScrollElasticityController.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lgombos
It seem to that rubber banding for Mac OS X meets the definition of the ...
7 years, 3 months ago (2013-09-20 03:13:20 UTC) #1
lgombos
7 years, 3 months ago (2013-09-20 03:13:32 UTC) #2
abarth-chromium
lgtm ok
7 years, 3 months ago (2013-09-20 16:02:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/24130008/1
7 years, 3 months ago (2013-09-20 16:02:41 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 19:45:09 UTC) #5
Message was sent while issue was closed. 
Change committed as 158135

Powered by Google App Engine
This is Rietveld 408576698