Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2410843002: Recipe fixes to support try jobs in task scheduler (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
borenet, dogben, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove unnecessary import #

Total comments: 2

Patch Set 3 : Fix recipe simulation #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -64 lines) Patch
M infra/bots/gen_tasks.go View 5 chunks +30 lines, -0 lines 0 comments Download
M infra/bots/recipe_modules/vars/api.py View 2 chunks +17 lines, -6 lines 0 comments Download
M infra/bots/recipes/swarm_compile.py View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/buildbotless_trybot_gerrit.json View 1 2 7 chunks +7 lines, -7 lines 1 comment Download
A + infra/bots/recipes/swarm_compile.expected/buildbotless_trybot_rietveld.json View 1 2 7 chunks +20 lines, -17 lines 0 comments Download
M infra/bots/recipes/upload_dm_results.py View 1 2 chunks +9 lines, -15 lines 0 comments Download
M infra/bots/recipes/upload_nano_results.py View 2 chunks +7 lines, -14 lines 0 comments Download
M infra/bots/tasks.json View 5 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
borenet
4 years, 2 months ago (2016-10-11 11:48:59 UTC) #3
borenet
The try result above is from the Task Scheduler. The link is broken right now ...
4 years, 2 months ago (2016-10-11 11:50:07 UTC) #4
dogben
lgtm Sorry, missed this earlier. I'm confused why the Win recipes seem to be doing ...
4 years, 2 months ago (2016-10-12 02:27:06 UTC) #5
borenet
https://codereview.chromium.org/2410843002/diff/20001/infra/bots/recipes/swarm_compile.expected/buildbotless_trybot_gerrit.json File infra/bots/recipes/swarm_compile.expected/buildbotless_trybot_gerrit.json (right): https://codereview.chromium.org/2410843002/diff/20001/infra/bots/recipes/swarm_compile.expected/buildbotless_trybot_gerrit.json#newcode28 infra/bots/recipes/swarm_compile.expected/buildbotless_trybot_gerrit.json:28: "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py", On 2016/10/12 02:27:06, dogben wrote: > Why is ...
4 years, 2 months ago (2016-10-13 12:32:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410843002/40001
4 years, 2 months ago (2016-10-13 12:50:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on master.client.skia.android (JOB_FAILED, http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot/builds/732)
4 years, 2 months ago (2016-10-13 13:03:39 UTC) #15
borenet
On 2016/10/13 13:03:39, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-13 13:05:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410843002/40001
4 years, 2 months ago (2016-10-13 13:05:09 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 13:23:48 UTC) #20
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/98b2e7a9e40a39799d09c01a3a35c8e336d8df29

Powered by Google App Engine
This is Rietveld 408576698