Recipe fixes to support try jobs in task scheduler

infra/bots/gen_tasks.go

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package main
 
 /*
         Generate the tasks.json file.
 */
 
@@ skipping 228 matching lines @@
                         pkgs = append(pkgs, getCipdPackage("win_vulkan_sdk"))
                 }
         }
 
         // Add the task.
         cfg.Tasks[name] = &specs.TaskSpec{
                 CipdPackages: pkgs,
                 Dimensions:   swarmDimensions(parts),
                 ExtraArgs: []string{
                         "--workdir", "../../..", "swarm_compile",
+                        "repository=skia",
                         fmt.Sprintf("buildername=%s", name),
                         "mastername=fake-master",
                         "buildnumber=2",
                         "slavename=fake-buildslave",
+                        "nobuildbot=True",
                         fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
                         fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+                        fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+                        fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+                        fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+                        fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
                 },
                 Isolate:  "compile_skia.isolate",
                 Priority: 0.8,
         }
         return name
 }
 
 // recreateSKPs generates a RecreateSKPs task. Returns the name of the last
 // task in the generated chain of tasks, which the Job should add as a
 // dependency.
@@ skipping 36 matching lines @@
 
 // test generates a Test task. Returns the name of the last task in the
 // generated chain of tasks, which the Job should add as a dependency.
 func test(cfg *specs.TasksCfg, name string, parts map[string]string, compileTaskName string, pkgs []*specs.CipdPackage) string {
         cfg.Tasks[name] = &specs.TaskSpec{
                 CipdPackages: pkgs,
                 Dependencies: []string{compileTaskName},
                 Dimensions:   swarmDimensions(parts),
                 ExtraArgs: []string{
                         "--workdir", "../../..", "swarm_test",
+                        "repository=skia",
                         fmt.Sprintf("buildername=%s", name),
                         "mastername=fake-master",
                         "buildnumber=2",
                         "slavename=fake-buildslave",
+                        "nobuildbot=True",
                         fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
                         fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+                        fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+                        fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+                        fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+                        fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
                 },
                 Isolate:  "test_skia.isolate",
                 Priority: 0.8,
         }
         // Upload results if necessary.
         if doUpload(name) {
                 uploadName := fmt.Sprintf("%s%s%s", PREFIX_UPLOAD, jobNameSchema.Sep, name)
                 cfg.Tasks[uploadName] = &specs.TaskSpec{
                         Dependencies: []string{name},
                         Dimensions:   UPLOAD_DIMENSIONS,
                         ExtraArgs: []string{
                                 "--workdir", "../../..", "upload_dm_results",
+                                "repository=skia",
                                 fmt.Sprintf("buildername=%s", name),
                                 "mastername=fake-master",
                                 "buildnumber=2",
                                 "slavename=fake-buildslave",
+                                "nobuildbot=True",
                                 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
                                 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+                                fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+                                fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+                                fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+                                fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
                         },
                         Isolate:  "upload_dm_results.isolate",
                         Priority: 0.8,
                 }
                 return uploadName
         }
         return name
 }
 
 // perf generates a Perf task. Returns the name of the last task in the
 // generated chain of tasks, which the Job should add as a dependency.
 func perf(cfg *specs.TasksCfg, name string, parts map[string]string, compileTaskName string, pkgs []*specs.CipdPackage) string {
         cfg.Tasks[name] = &specs.TaskSpec{
                 CipdPackages: pkgs,
                 Dependencies: []string{compileTaskName},
                 Dimensions:   swarmDimensions(parts),
                 ExtraArgs: []string{
                         "--workdir", "../../..", "swarm_perf",
+                        "repository=skia",
                         fmt.Sprintf("buildername=%s", name),
                         "mastername=fake-master",
                         "buildnumber=2",
                         "slavename=fake-buildslave",
+                        "nobuildbot=True",
                         fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
                         fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+                        fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+                        fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+                        fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+                        fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
                 },
                 Isolate:  "perf_skia.isolate",
                 Priority: 0.8,
         }
         // Upload results if necessary.
         if strings.Contains(name, "Release") && doUpload(name) {
                 uploadName := fmt.Sprintf("%s%s%s", PREFIX_UPLOAD, jobNameSchema.Sep, name)
                 cfg.Tasks[uploadName] = &specs.TaskSpec{
                         Dependencies: []string{name},
                         Dimensions:   UPLOAD_DIMENSIONS,
                         ExtraArgs: []string{
                                 "--workdir", "../../..", "upload_nano_results",
+                                "repository=skia",
                                 fmt.Sprintf("buildername=%s", name),
                                 "mastername=fake-master",
                                 "buildnumber=2",
                                 "slavename=fake-buildslave",
+                                "nobuildbot=True",
                                 fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
                                 fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+                                fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+                                fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+                                fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+                                fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
                         },
                         Isolate:  "upload_nano_results.isolate",
                         Priority: 0.8,
                 }
                 return uploadName
         }
         return name
 }
 
 // process generates tasks and jobs for the given job name.
@@ skipping 209 matching lines @@
                 if !ok {
                         return "", fmt.Errorf("Invalid job parts; missing %q", k)
                 }
                 rvParts = append(rvParts, v)
         }
         if _, ok := parts["extra_config"]; ok {
                 rvParts = append(rvParts, parts["extra_config"])
         }
         return strings.Join(rvParts, s.Sep), nil
 }