Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: infra/bots/gen_tasks.go

Issue 2410843002: Recipe fixes to support try jobs in task scheduler (Closed)
Patch Set: Fix recipe simulation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/gen_tasks.go
diff --git a/infra/bots/gen_tasks.go b/infra/bots/gen_tasks.go
index 0751124368c73f4cda8ac29e18ee8c5eebb402f3..25bcc5d2e8d80642b3b79c584b2496a2a805c680 100644
--- a/infra/bots/gen_tasks.go
+++ b/infra/bots/gen_tasks.go
@@ -246,12 +246,18 @@ func compile(cfg *specs.TasksCfg, name string, parts map[string]string) string {
Dimensions: swarmDimensions(parts),
ExtraArgs: []string{
"--workdir", "../../..", "swarm_compile",
+ "repository=skia",
fmt.Sprintf("buildername=%s", name),
"mastername=fake-master",
"buildnumber=2",
"slavename=fake-buildslave",
+ "nobuildbot=True",
fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+ fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+ fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+ fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+ fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
},
Isolate: "compile_skia.isolate",
Priority: 0.8,
@@ -308,12 +314,18 @@ func test(cfg *specs.TasksCfg, name string, parts map[string]string, compileTask
Dimensions: swarmDimensions(parts),
ExtraArgs: []string{
"--workdir", "../../..", "swarm_test",
+ "repository=skia",
fmt.Sprintf("buildername=%s", name),
"mastername=fake-master",
"buildnumber=2",
"slavename=fake-buildslave",
+ "nobuildbot=True",
fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+ fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+ fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+ fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+ fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
},
Isolate: "test_skia.isolate",
Priority: 0.8,
@@ -326,12 +338,18 @@ func test(cfg *specs.TasksCfg, name string, parts map[string]string, compileTask
Dimensions: UPLOAD_DIMENSIONS,
ExtraArgs: []string{
"--workdir", "../../..", "upload_dm_results",
+ "repository=skia",
fmt.Sprintf("buildername=%s", name),
"mastername=fake-master",
"buildnumber=2",
"slavename=fake-buildslave",
+ "nobuildbot=True",
fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+ fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+ fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+ fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+ fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
},
Isolate: "upload_dm_results.isolate",
Priority: 0.8,
@@ -350,12 +368,18 @@ func perf(cfg *specs.TasksCfg, name string, parts map[string]string, compileTask
Dimensions: swarmDimensions(parts),
ExtraArgs: []string{
"--workdir", "../../..", "swarm_perf",
+ "repository=skia",
fmt.Sprintf("buildername=%s", name),
"mastername=fake-master",
"buildnumber=2",
"slavename=fake-buildslave",
+ "nobuildbot=True",
fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+ fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+ fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+ fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+ fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
},
Isolate: "perf_skia.isolate",
Priority: 0.8,
@@ -368,12 +392,18 @@ func perf(cfg *specs.TasksCfg, name string, parts map[string]string, compileTask
Dimensions: UPLOAD_DIMENSIONS,
ExtraArgs: []string{
"--workdir", "../../..", "upload_nano_results",
+ "repository=skia",
fmt.Sprintf("buildername=%s", name),
"mastername=fake-master",
"buildnumber=2",
"slavename=fake-buildslave",
+ "nobuildbot=True",
fmt.Sprintf("swarm_out_dir=%s", specs.PLACEHOLDER_ISOLATED_OUTDIR),
fmt.Sprintf("revision=%s", specs.PLACEHOLDER_REVISION),
+ fmt.Sprintf("patch_storage=%s", specs.PLACEHOLDER_PATCH_STORAGE),
+ fmt.Sprintf("%s=%s", specs.PLACEHOLDER_PATCH_STORAGE, specs.PLACEHOLDER_CODEREVIEW_SERVER),
+ fmt.Sprintf("issue=%s", specs.PLACEHOLDER_ISSUE),
+ fmt.Sprintf("patchset=%s", specs.PLACEHOLDER_PATCHSET),
},
Isolate: "upload_nano_results.isolate",
Priority: 0.8,

Powered by Google App Engine
This is Rietveld 408576698