Recipe fixes to support try jobs in task scheduler

infra/bots/recipe_modules/vars/api.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 # pylint: disable=W0201
 
 
 from recipe_engine import recipe_api
 
@@ skipping 16 matching lines @@
     self.builder_name = self.m.properties['buildername']
     self.master_name = self.m.properties['mastername']
     self.slave_name = self.m.properties['slavename']
     self.build_number = self.m.properties['buildnumber']
 
     self.slave_dir = self.m.path['slave_build']
     self.checkout_root = self.slave_dir
     self.default_env = {}
     self.gclient_env = {}
     self.is_compile_bot = self.builder_name.startswith('Build-')
+    self.no_buildbot = self.m.properties.get('nobuildbot', '') == 'True'
 
     self.default_env['CHROME_HEADLESS'] = '1'
     # The 'depot_tools' directory comes from recipe DEPS and isn't provided by
     # default. We have to set it manually.
     self.m.path.c.base_paths['depot_tools'] = (
         self.m.path.c.base_paths['slave_build'] +
         ('skia', 'infra', 'bots', '.recipe_deps', 'depot_tools'))
     if 'Win' in self.builder_name:
       self.m.path.c.base_paths['depot_tools'] = (
           'c:\\', 'Users', 'chrome-bot', 'depot_tools')
@@ skipping 52 matching lines @@
     if self.role == self.m.builder_name_schema.BUILDER_ROLE_HOUSEKEEPER:
       self.configuration = CONFIG_RELEASE
     else:
       self.configuration = self.builder_cfg.get('configuration', CONFIG_DEBUG)
     arch = (self.builder_cfg.get('arch') or self.builder_cfg.get('target_arch'))
     if ('Win' in self.builder_cfg.get('os', '') and arch == 'x86_64'):
       self.configuration += '_x64'
 
     self.default_env.update({'SKIA_OUT': self.skia_out,
                              'BUILDTYPE': self.configuration})
-    self.is_trybot = self.builder_cfg['is_trybot']
+
     self.patch_storage = self.m.properties.get('patch_storage', 'rietveld')
     self.issue = None
     self.patchset = None
-    if self.is_trybot:
-      if self.patch_storage == 'gerrit':
-        self.issue = self.m.properties['event.change.number']
-        self.patchset = self.m.properties['event.patchSet.ref'].split('/')[-1]
-      else:
+    if self.no_buildbot:
+      self.is_trybot = (
+          self.m.properties.get('issue', '') and
+          self.m.properties.get('patchset', ''))
+      if self.is_trybot:
         self.issue = self.m.properties['issue']
         self.patchset = self.m.properties['patchset']
+    else:
+      self.is_trybot = self.builder_cfg['is_trybot']
+      if self.is_trybot:
+        if self.patch_storage == 'gerrit':
+          self.issue = self.m.properties['event.change.number']
+          self.patchset = self.m.properties['event.patchSet.ref'].split('/')[-1]
+        else:
+          self.issue = self.m.properties['issue']
+          self.patchset = self.m.properties['patchset']
+
     self.dm_dir = self.m.path.join(
         self.swarming_out_dir, 'dm')
     self.perf_data_dir = self.m.path.join(self.swarming_out_dir,
         'perfdata', self.builder_name, 'data')
 
   @property
   def upload_dm_results(self):
     # TODO(borenet): Move this into the swarm_test recipe.
     skip_upload_bots = [
       'ASAN',
@@ skipping 22 matching lines @@
       'TSAN',
       'UBSAN',
       'Valgrind',
     ]
     upload_perf_results = True
     for s in skip_upload_bots:
       if s in self.m.properties['buildername']:
         upload_perf_results = False
         break
     return upload_perf_results