Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/extensions/external_install_error.cc

Index: chrome/browser/extensions/external_install_error.cc
diff --git a/chrome/browser/extensions/external_install_error.cc b/chrome/browser/extensions/external_install_error.cc
index aa17a9488da1854e01f8ce98a20575afd5069cb2..caca9ef90d777596c224628ee6d1dd13611fcade 100644
--- a/chrome/browser/extensions/external_install_error.cc
+++ b/chrome/browser/extensions/external_install_error.cc
@@ -313,7 +313,7 @@ ExternalInstallError::ExternalInstallError(
 
 ExternalInstallError::~ExternalInstallError() {
   if (global_error_.get())
-    error_service_->RemoveGlobalError(global_error_.get());
+    error_service_->RemoveUnownedGlobalError(global_error_.get());
 }
 
 void ExternalInstallError::OnInstallPromptDone(
@@ -439,7 +439,7 @@ void ExternalInstallError::OnDialogReady(
 
   if (alert_type_ == BUBBLE_ALERT) {
     global_error_.reset(new ExternalInstallBubbleAlert(this, prompt_.get()));

[Nico, 2016/10/10 14:03:37]

This one looks like it could be a weak ptr and this class could use the
AddOwned() version throughout

[Avi (use Gerrit), 2016/10/10 16:52:36]

The GlobalErrorService is a PKS, and is guaranteed to outlive this, so I'm
making it a weak pointer.

-    error_service_->AddGlobalError(global_error_.get());
+    error_service_->AddUnownedGlobalError(global_error_.get());
 
     if (!manager_->has_currently_visible_install_alert()) {
       // |browser| is nullptr during unit tests, so call
@@ -454,7 +454,7 @@ void ExternalInstallError::OnDialogReady(
   } else {
     DCHECK(alert_type_ == MENU_ALERT);
     global_error_.reset(new ExternalInstallMenuAlert(this));
-    error_service_->AddGlobalError(global_error_.get());
+    error_service_->AddUnownedGlobalError(global_error_.get());
   }
 }