Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/extensions/extension_disabled_ui.cc

Index: chrome/browser/extensions/extension_disabled_ui.cc
diff --git a/chrome/browser/extensions/extension_disabled_ui.cc b/chrome/browser/extensions/extension_disabled_ui.cc
index f23350b69c8119c24814b2027dbcd0059aae42f2..c2d35ffc0a12841323dd00a45f6779795a175c18 100644
--- a/chrome/browser/extensions/extension_disabled_ui.cc
+++ b/chrome/browser/extensions/extension_disabled_ui.cc
@@ -431,7 +431,7 @@ void ExtensionDisabledGlobalError::OnShutdown(
 
 void ExtensionDisabledGlobalError::RemoveGlobalError() {
   GlobalErrorServiceFactory::GetForProfile(service_->profile())
-      ->RemoveGlobalError(this);
+      ->RemoveOwnedGlobalError(this).release();

[Nico, 2016/10/10 14:03:37]

Hm, I think this'd be nicer if it stored the result in a local and then called
release right next to the call to DeleteSoon().

DeleteSoon() should probably have a version taking a unique_ptr, then the return
value could be moved to DeleteSoon().

[Avi (use Gerrit), 2016/10/10 16:52:36]

Done.

   registrar_.RemoveAll();
   registry_observer_.RemoveAll();
   // Delete this object after any running tasks, so that the extension dialog
@@ -452,7 +452,7 @@ void AddExtensionDisabledErrorWithIcon(base::WeakPtr<ExtensionService> service,
   const Extension* extension = service->GetInstalledExtension(extension_id);
   if (extension) {
     GlobalErrorServiceFactory::GetForProfile(service->profile())
-        ->AddGlobalError(new ExtensionDisabledGlobalError(
+        ->AddOwnedGlobalError(base::MakeUnique<ExtensionDisabledGlobalError>(
             service.get(), extension, is_remote_install, icon));
   }
 }